From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753584AbeAZPNR (ORCPT ); Fri, 26 Jan 2018 10:13:17 -0500 Received: from dispatch1-us1.ppe-hosted.com ([148.163.129.52]:54078 "EHLO dispatch1-us1.ppe-hosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932136AbeAZPNM (ORCPT ); Fri, 26 Jan 2018 10:13:12 -0500 From: Edward Cree Subject: Re: [RFC PATCH net-next] sfc: efx_default_channel_want_txqs() can be static To: kbuild test robot , David Miller CC: , , Solarflare linux maintainers , Bert Kenward , References: <201801260928.N1021lrX%fengguang.wu@intel.com> <20180126010304.GA87465@cairo> Message-ID: <8f502691-13cc-5128-43dd-36a17ec8bcc2@solarflare.com> Date: Fri, 26 Jan 2018 15:13:05 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180126010304.GA87465@cairo> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-Originating-IP: [10.17.20.45] X-MDID: 1516979591-uHbtvpv7Sg6H Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/01/18 01:03, kbuild test robot wrote: > Fixes: 2935e3c38228 ("sfc: on 8000 series use TX queues for TX timestamps") > Signed-off-by: Fengguang Wu Acked-by: Edward Cree Dave, can you take this directly or do you need it reposted without RFC tags?  I'm not sure what the procedure is for robopatches. > --- > efx.c | 2 +- > ptp.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c > index 456866b0..16757cf 100644 > --- a/drivers/net/ethernet/sfc/efx.c > +++ b/drivers/net/ethernet/sfc/efx.c > @@ -896,7 +896,7 @@ void efx_schedule_slow_fill(struct efx_rx_queue *rx_queue) > mod_timer(&rx_queue->slow_fill, jiffies + msecs_to_jiffies(100)); > } > > -bool efx_default_channel_want_txqs(struct efx_channel *channel) > +static bool efx_default_channel_want_txqs(struct efx_channel *channel) > { > return channel->channel - channel->efx->tx_channel_offset < > channel->efx->n_tx_channels; > diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c > index 433d29d..3e2c5b1 100644 > --- a/drivers/net/ethernet/sfc/ptp.c > +++ b/drivers/net/ethernet/sfc/ptp.c > @@ -366,7 +366,7 @@ bool efx_ptp_use_mac_tx_timestamps(struct efx_nic *efx) > /* PTP 'extra' channel is still a traffic channel, but we only create TX queues > * if PTP uses MAC TX timestamps, not if PTP uses the MC directly to transmit. > */ > -bool efx_ptp_want_txqs(struct efx_channel *channel) > +static bool efx_ptp_want_txqs(struct efx_channel *channel) > { > return efx_ptp_use_mac_tx_timestamps(channel->efx); > } > @@ -2146,7 +2146,7 @@ static int efx_phc_enable(struct ptp_clock_info *ptp, > return 0; > } > > -const struct efx_channel_type efx_ptp_channel_type = { > +static const struct efx_channel_type efx_ptp_channel_type = { > .handle_no_channel = efx_ptp_handle_no_channel, > .pre_probe = efx_ptp_probe_channel, > .post_remove = efx_ptp_remove_channel,