From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32C501C8634 for ; Tue, 17 Feb 2026 11:56:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771329366; cv=none; b=c71AZJmxsp5PgV1NG7weZsB8MNCaoDTi5POXfGQscx7Hdbl/eQzFxJaSWqD0Csd38UIxe5ANcBVH3au3m9dLeep9VQpkPG9md/ipHkNlfO5BkbawSW09e0gQRkY61ixpiVnND/yTTepKHpWMnszIitYxOvIrpEgkWqluHRaXOn0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771329366; c=relaxed/simple; bh=IHpTnHZt7SzXUK/S7kX+tVLZoFmFUaqjAJBhLbkKzBs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZcFTvrcQT8yjMnkpWFzl37g2TFhSMv9REGv1s1KGQq7CMVjn1jtfLTQ5+npcpFz56FPO5ynAMJo+2w/vQ4UfBKLbSC8cIEzkgIRKFsshpDk66xJn5ZhJeEklO926ipCQsbKKjkD9aOFhyLmvYXSjiAG6+JWC96kNU8Fmm84enG4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IrCXI1oP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eUhJEcU/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IrCXI1oP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eUhJEcU/" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61HB1jOU912069 for ; Tue, 17 Feb 2026 11:56:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ci8ERzFPh/SxO4CXB6i8rjaINK9R5am3AqF7jJdUFgU=; b=IrCXI1oPXv0C4YD/ fGzBQe8+C4rOxiuk3phBVlrbX2VpvjvKDwAMO3QHJbo/1ORm7CYJ8Z36LcDfah1f RaPk4dVYPvQynlvLuhv3N5bXyfeVJcCfin63kzGra9m09/lF/K3LwGXbl/zIXKTR yJD1m1B6Z0dYfH0csXLxIqBmodn1+hNmLvG21TigcwOM3470ks0IB8z7jkiJwO6L jaxPNp7/nBCmVTn9BiWv7vkUej+yB68dtnkhCGpQQNyEDNdV37qDdhG5SXf04mIJ XJzjgF/+pIi5KZNVgS1XLKbmP+F04k9te7h1RX00Stj/Ym0fCB6hCUED/GYnzzAb m4PoOg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cc6a9t7ev-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Feb 2026 11:56:03 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-506b3baa69eso36924261cf.2 for ; Tue, 17 Feb 2026 03:56:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771329362; x=1771934162; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ci8ERzFPh/SxO4CXB6i8rjaINK9R5am3AqF7jJdUFgU=; b=eUhJEcU/2nCSL2wczUzhW8cRZSk36dTFvXy508Ms0MVpsXpMLZQ9AG00fSwzh6fJuz JgQ7sERrxXPBWsL2FqHS7MQsXl+yjWigry01hW+PLkedZfvGYAyIZmyRxl5dbdr5IK1f BOnp5b/alJO0msTAa1nUCszKXomEJ5COr6GoYdgbHYsiqWVcWRsHmOtVQlXtzrkM9mY7 2Cp3GOl7/uXpCKFxf7zhM3606YNur2nPTf8lniMoSlWvIB94+JlUNvL5vFmkxyEwB1sY HZRCAA+Z/6VxyKf0tD4NfPOCz4yuRM75dbOfjP5SFwtWsCg65kXmAQwAebxt1Po4dqgK Wq9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771329362; x=1771934162; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ci8ERzFPh/SxO4CXB6i8rjaINK9R5am3AqF7jJdUFgU=; b=f9CIh8cL8YnqwcVyeyGjDOPn6G8pRitSJZ4BuhWG9aU+6OfOLtkR5rj3DbgFj5TXEA A7P1OOdjEAO1yyRczGFDv4E0K6c6O0pLQkxQMIZMdqnkOujzT5hecKKNgObzgZGfkbEX S0bPyQHI+eujGhYhxgLzEscYZEfi5J7z64qkckaTtDJfp18pert/S+RCARJdPkqERdAK fjtaeV5PyHjsCzRBsnRNU/MFwGDWQhL1f8yGW/cZSbHUUDp1KbeEgb56r6HIysKOXTgy 3ExhEAB92BGSFMRmN/Y/EJP2to5hn3UHxYFygUPMNQfV92gE5l7lSPJywAhhanfY/d0U j0lA== X-Forwarded-Encrypted: i=1; AJvYcCVYzPJmsY6aJaFV1clFtprHwIYW3kAm5A4gf70PNt4D/VbPJjXfZr58iMuxMqRxIwEFN8+tnGdt91+aWq4=@vger.kernel.org X-Gm-Message-State: AOJu0YzkQhzvwNa4zHGncKyClxDxKnZZ3ThmX9YpTcnBa9z9IIKNbHUc BYCRpo/ikmx4NE4s/MqrId5runoPKWyoDc8xXwkBgarKsPy8mlnEBfGfMiIiMJhFDs7U8fpetPC AOczdWFRgXedSUXXZnPuc0R9ULzOeX5KVDQJsd+yi6KMnN6loF+nqbrBhxq5cTWdnDIM= X-Gm-Gg: AZuq6aJeWgv30Em3cSJtaj5Aofxan29cO1izFdS7srMQ6qnDOHkqJt2s6bSF3r1U8bS SfzjLUxd5gC+RKEg1O5zcpFqoACbeuk5mSTAf/IRq/HBBklHzKdQyaiC1h5PlRd4nvIBsdvQ9m/ wYLjuYoxNw8T802knMeVrIAeexmcsrhTzmULH6F++VyXSojnt335Mlden2jSfyTWR7A0aW3rkao B7pPV7B1b7whs2eCx2scNHRcb95p+Xa9wYlGJIopnoGBaENDXJ/N2uTReb8/zJzrfSWAY2zbbvQ 8oyIvyBhkjUL+bfFpg2Bg6edrzu+q/aQkCwu1nQFRNhSCxZIbyhrlzP3n1GjY9PrM9g9BpMD/G9 RXBTq/lZLsdR4TDPBLYk+sjUdeznRlKKFVcMYuUN1wpUtd2W82jFwzqUEeKhdUGu//PZqpmzdkX 9DmGE= X-Received: by 2002:ac8:5890:0:b0:4e6:eaff:3a4b with SMTP id d75a77b69052e-506a67af949mr130225661cf.4.1771329362559; Tue, 17 Feb 2026 03:56:02 -0800 (PST) X-Received: by 2002:ac8:5890:0:b0:4e6:eaff:3a4b with SMTP id d75a77b69052e-506a67af949mr130225521cf.4.1771329362067; Tue, 17 Feb 2026 03:56:02 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65bad3e39ebsm2333308a12.18.2026.02.17.03.55.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Feb 2026 03:56:01 -0800 (PST) Message-ID: <8f52d9de-2639-4bbd-9ae1-4d55ba13422c@oss.qualcomm.com> Date: Tue, 17 Feb 2026 12:55:57 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 11/13] i2c: qcom-geni: Use resources helper APIs in runtime PM functions To: Praveen Talari , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, chiluka.harish@oss.qualcomm.com References: <20260206174112.4149893-1-praveen.talari@oss.qualcomm.com> <20260206174112.4149893-12-praveen.talari@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260206174112.4149893-12-praveen.talari@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE3MDA5OSBTYWx0ZWRfX+TppE7SI83hx Jf/u0Twu2fgxLvDKei5Mw1MyHgNwEoDNqYT7l7RxIyPpJNOqM+bQucbkbuTVDBMEHH3AELdp6Nl skbKlGAQliz6ppVUYrR1ix9Lt2b6CasnLelX+5fctU8WCoCu9rK72C10Svgu3oV3QyAWT8MnT4N 9Vfo0NgThjtHuI1Cpt8ZB2UqTz+cZeE0WkibjmCgfnZVkPGHOu9wfU7ytOQ74EFX0kkp8uePX3x Ju90NQ6guFNy+jzghdgvLBtZUPKM8MPlGj84GrKLu+4l77fO1hHUjsyT6PqvSqS2+oFpDllZpZ0 4UEbf4I5d0we2+FYfcar44/G6dAfLV1+jwttdqJX/RVados4ux9NzcGCGGGtO/WReY7bBdUS9e/ jR1cHHjXNb8BoFsnK9hSpF1iBBch0h+8deXGnEtRm23PAbnxGX7a1zh5NRyndV0GEL3zk/Qh5Rn 5JV39iHIZTawz2vKwDw== X-Proofpoint-GUID: wOxUlz1I_8iM9XYmd2a88dMr2_Qummfo X-Proofpoint-ORIG-GUID: wOxUlz1I_8iM9XYmd2a88dMr2_Qummfo X-Authority-Analysis: v=2.4 cv=TPNIilla c=1 sm=1 tr=0 ts=69945753 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=gzD-2WDeCj_JQFVUwcoA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-17_01,2026-02-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 spamscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602170099 On 2/6/26 6:41 PM, Praveen Talari wrote: > To manage GENI serial engine resources during runtime power management, > drivers currently need to call functions for ICC, clock, and > SE resource operations in both suspend and resume paths, resulting in > code duplication across drivers. > > The new geni_se_resources_activate() and geni_se_resources_deactivate() > helper APIs addresses this issue by providing a streamlined method to > enable or disable all resources based, thereby eliminating redundancy > across drivers. > > Acked-by: Viken Dadhaniya > Signed-off-by: Praveen Talari > --- > v3->v4: > - Added Acked-by tag. > > v1->v2: > Bjorn: > - Remove geni_se_resources_state() API. > - Used geni_se_resources_activate() and geni_se_resources_deactivate() > to enable/disable resources. > --- > drivers/i2c/busses/i2c-qcom-geni.c | 28 +++++----------------------- > 1 file changed, 5 insertions(+), 23 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > index 05f5705b0319..0ddfeef6d1b2 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -1160,18 +1160,15 @@ static int __maybe_unused geni_i2c_runtime_suspend(struct device *dev) > struct geni_i2c_dev *gi2c = dev_get_drvdata(dev); > > disable_irq(gi2c->irq); > - ret = geni_se_resources_off(&gi2c->se); > + > + ret = geni_se_resources_deactivate(&gi2c->se); > if (ret) { > enable_irq(gi2c->irq); > return ret; > - > - } else { > - gi2c->suspended = 1; > } > > - clk_disable_unprepare(gi2c->se.core_clk); > - > - return geni_icc_disable(&gi2c->se); > + gi2c->suspended = 1; > + return ret; Both of these functions can now only return 0 in the last 'return' Reviewed-by: Konrad Dybcio Konrad