From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA466375F67 for ; Fri, 6 Mar 2026 22:12:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772835159; cv=none; b=rKHINY0LE8ziG2vhxM1dH+Kq5W8h+iRKlPyLP9Fb6bYfBX+mSqHLCZD4ho0ZdMIfres3FFEQhRHPgzsx5wQXeH+ILUBDrkpagYidNqSLsyJFXi3gr+1M3rnJTg3xG9iWy7uuevRH1aI4fIDHlMJQJRFdGb5mNPpcc9hvpiWlIXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772835159; c=relaxed/simple; bh=Hs+MBb04Lyzo880e9nk8eI+d8SukZx9jsCRlpJ45bJ0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I+gCPUQ9us/qJ4crrXwRY1MIVd/pmSJ1x7hOaPRZtVNVLpKxUL5D1M7a6o1HQdQkxCoocEe5MgV6kpjNofiek+bWhBh6lHHCNEtQuHCC/1J4oskSR9V5M0CvW8zocsDQEQa6lrmtNWLbSjbPeFZjVfEqDNSRcBO/G9TG1vOaQVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=CcXROxbt; arc=none smtp.client-ip=209.85.161.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="CcXROxbt" Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-66e3100515dso5732049eaf.2 for ; Fri, 06 Mar 2026 14:12:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1772835156; x=1773439956; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ew/B/937aczEKs4JzvmAwfq3QMOO8uG9SLncMIG9tjs=; b=CcXROxbt2bAkgFlcCmE9Lm4MMFf8/neUtwRmGEm9cWGVZ5kOyEXqMUQtWDOELqD41w VZsXupT6jnjXDYmFWqXtL7GNj4t3JmgT8hSjEOSqJluLif1oFvBV9CcsJjkN9HNz7zzo hLsuhkmbDAD25FZXCagTkqksNeyxZvWeRv6ggUmq9F3AcDjbAUi4kOpkMwI6RgSElkA9 c1BiKzivU/U630UZNQFD9M1BaeJRtdykQn5IUB0ktBPS4lqhSo//u52J9ck7Egv/yA3I /xmKtn4Sga2PVEZ7FxcPoxcwFNZO2TqVYXWrM5d4wXGDQTF7Ahmxa1vWOYqxcUWbNogr EKow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772835156; x=1773439956; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ew/B/937aczEKs4JzvmAwfq3QMOO8uG9SLncMIG9tjs=; b=d6y3OXVoSydrPLeug3rGwqmwtlzKIyvCcErx/XAYbHU0BiArYeEbXg/C4rBTVe7bIT IYDXwxdVcnsR8oMQcXrQkYK+bXuEXNgAR2zRqt5m3DbkpIK48throFeFgLQbTcEOBjxw 3/zBvJ19aXcUJBHoDVFb4z774d9bqPN/l+x9Ak41X7ElAIuRKoC4lcG0cVT8wbQHLpd0 FoTV8C1xZqhY3JKo/ys5vWwlx9xQwSO7JW3AAmcNpNZ+/ot1gNhV37VBO7h4cLGpFsSh 6amLRIXP3udQY025P8eO3bMphGVQHiIGsUHCAFMjijhBj37/6xYMkyK2ngeLWVmCIlRR DLfA== X-Forwarded-Encrypted: i=1; AJvYcCVmVdmgjrpENmFJCiDyBPtxUp1oxr0jyinwD14HCN0/XEB0Z2DPe5M68KFe2dK3X0FjqCftxVz3vnLiUTg=@vger.kernel.org X-Gm-Message-State: AOJu0YxGpX7UjBkJ9GOUja/4ld1rCGPluF8oS5a2mvDw5Qi+d8XaUo7z 50ODfmjD2e3Nm5QDLIw1J9+WZCh3A7pRy4kcpfQYSd5MrL/YCCLrZU6mKozgMZs2EoAF0IydcdW Sm8SN X-Gm-Gg: ATEYQzzleeXmT1h9ZNLyYTjb9TVR03Kql+1N0SWwiJkvKZZ3Lz70AN+63tEpPsqQ5Wr F9zpJPFKQ39h/PoZ04wSghB0CRKvRTCFWZn6rgIJSPWiuQEawex5oQ+xfW8wWQns8+TGuIFyW82 2rnuLVh7+2TWomrbGv64lfi6g3vCVdefUziWB3jOPQaG1rohKYtyhTFP9aQWL1jhO3nUYeNWoyv OliWiWF7yRjQR4DpwnqWc1MvZJn2zJ8lTMb1dSBYDerlRMarnBuPhUTBKDTiC9QiL8don4rau+g G8jpQ81ujd+GaWnDE2IWAA6h7F0r9nWKbTp1VYbeRKn6wGQMoUUrEOm7HAMauCj5XIvuYHexiQL QmvEU1i3u8AfRy+UWZj7JFhLfsCGDceTWJcVb7RxcJzbyzK7tQPvsMT/5KwyXriEys7ibND78IF f2hpmyE1/blStzg1BK0VXeQFSHrI3dftY99kdB+Y1LUBywJO67Q3K1U0qQoVq9gzSuVnjEESITG g== X-Received: by 2002:a05:6820:450b:b0:677:8da:286d with SMTP id 006d021491bc7-67b9bd16918mr1703424eaf.49.1772835156649; Fri, 06 Mar 2026 14:12:36 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:6d78:b98b:fc05:ddbe? ([2600:8803:e7e4:500:6d78:b98b:fc05:ddbe]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-67b9d517fb4sm1611438eaf.15.2026.03.06.14.12.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2026 14:12:36 -0800 (PST) Message-ID: <8f532495-868b-4e69-bec0-0e6e12b7b959@baylibre.com> Date: Fri, 6 Mar 2026 16:12:35 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] iio: accel: adxl355: convert to guard(mutex) To: Rajveer Chaudhari , lucas.p.stankus@gmail.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, nuno.sa@analog.com, andy@kernel.org, puranjay@kernel.org Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260306211152.65109-1-rajveer.chaudhari.linux@gmail.com> <20260306211152.65109-3-rajveer.chaudhari.linux@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260306211152.65109-3-rajveer.chaudhari.linux@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/6/26 3:11 PM, Rajveer Chaudhari wrote: > --- > drivers/iio/accel/adxl355_core.c | 27 ++++++++------------------- > 1 file changed, 8 insertions(+), 19 deletions(-) > > diff --git a/drivers/iio/accel/adxl355_core.c b/drivers/iio/accel/adxl355_core.c > index 1c1d64d5cbcb..ef05178bff00 100644 > --- a/drivers/iio/accel/adxl355_core.c > +++ b/drivers/iio/accel/adxl355_core.c > @@ -9,6 +9,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -263,12 +264,11 @@ static int adxl355_data_rdy_trigger_set_state(struct iio_trigger *trig, > struct adxl355_data *data = iio_priv(indio_dev); > int ret; > > - mutex_lock(&data->lock); > + guard(mutex)(&data->lock); > ret = regmap_update_bits(data->regmap, ADXL355_POWER_CTL_REG, > ADXL355_POWER_CTL_DRDY_MSK, > FIELD_PREP(ADXL355_POWER_CTL_DRDY_MSK, > state ? 0 : 1)); Same principal applies here: return regmap_update_bits(data->regmap, ADXL355_POWER_CTL_REG, ADXL355_POWER_CTL_DRDY_MSK, FIELD_PREP(ADXL355_POWER_CTL_DRDY_MSK, state ? 0 : 1)); Then we can remove `ret` entirely. Similar changes can be made in most other functions as well. > - mutex_unlock(&data->lock); > > return ret; > } ... > @@ -448,16 +444,15 @@ static int adxl355_set_hpf_3db(struct adxl355_data *data, > { > int ret; > > - mutex_lock(&data->lock); > + guard(mutex)(&data->lock); > > if (data->hpf_3db == hpf) { > - mutex_unlock(&data->lock); > return 0; > } > > ret = adxl355_set_op_mode(data, ADXL355_STANDBY); > if (ret) > - goto err_unlock; > + return ret; > > ret = regmap_update_bits(data->regmap, ADXL355_FILTER_REG, > ADXL355_FILTER_HPF_MSK, > @@ -471,13 +466,10 @@ static int adxl355_set_hpf_3db(struct adxl355_data *data, > if (ret) > goto err_set_opmode; If we aren't getting rid of all of the gotos, we are doing it wrong. Same applies in other functions as well. > > - mutex_unlock(&data->lock); > return 0; > > err_set_opmode: > adxl355_set_op_mode(data, ADXL355_MEASUREMENT); > -err_unlock: > - mutex_unlock(&data->lock); > return ret; > }