From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD962C4332F for ; Mon, 14 Feb 2022 20:59:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229655AbiBNVAG (ORCPT ); Mon, 14 Feb 2022 16:00:06 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:60012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229943AbiBNVAA (ORCPT ); Mon, 14 Feb 2022 16:00:00 -0500 Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CD8715B982 for ; Mon, 14 Feb 2022 12:59:44 -0800 (PST) Received: by mail-io1-xd34.google.com with SMTP id y84so21568578iof.0 for ; Mon, 14 Feb 2022 12:59:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=04Ox5ixc4MPOE8Kua318ZsUJMu3rT8ky9xRJXJOyxF0=; b=aA8xCND2MGx+5OMZd1UPNNR3bzouVZeF3Pp/V3gAI6Y6VO3YKteYVgspznUv2NetBF Tc+o47xNGteAJPsCxg6xm0s7PLkDEAwdTocbmUrOX9vXxnJLf0YnFX9foX4HCjROGp2r J+OtRald/QoJMCAX6q501eL6WJoD9BwpZGyWM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=04Ox5ixc4MPOE8Kua318ZsUJMu3rT8ky9xRJXJOyxF0=; b=OQQRa+NIvQUckf1xPTdbcxybdEDvWTLvJHLtRiScIH+5mBT+td2MxrU6QV+/BQMgMt iUw0XmC6PIpVVtLXSrWp3MLLlyccJO4H4kmtQcsJs5g6N3i932elyylBQuSQPYCzM5Fg Doa9XDC+aKxs5hiSe9zQCckV5BnG0x6nvz1KRadaam3mTyiQOvOE5ONOttLe9v2eP+rF fS6rfWLN2eHtfVBTecgOI3XjOyHB7hxuZQG53/NuRdnrP2A7R+CZsMdDQKdsZev3vXQH BOwXeTrN72iI1fz8TaLpaHiWny9dChZxsbF14gBYbk22m6uRTJKJ+lYf0r0b8pvAILA+ f29A== X-Gm-Message-State: AOAM533nJQtlrN27AMjO6Fb08VbAVFPR7u36a90WPanmaNF9ASJAqQCJ jLYCdR5Fsyig9+U53kM1KsIiAQ== X-Google-Smtp-Source: ABdhPJxOoTHzsjxeSWDebsZYfsiGHhSEEz60eKm+tUhCUtGJPeoRbM/EPLiEntjejkgFvCzl/lMIBQ== X-Received: by 2002:a05:6638:190a:: with SMTP id p10mr477555jal.313.1644872383619; Mon, 14 Feb 2022 12:59:43 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id w10sm21193066iow.44.2022.02.14.12.59.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Feb 2022 12:59:43 -0800 (PST) Subject: Re: [PATCH V2 1/2] selftests: x86: add validity check and allow field splitting To: Muhammad Usama Anjum , Jarkko Sakkinen , Dave Hansen , Shuah Khan , Andy Lutomirski , Jethro Beekman , Borislav Petkov , "open list:INTEL SGX" , "open list:KERNEL SELFTEST FRAMEWORK" , open list , David.Laight@ACULAB.COM Cc: kernel@collabora.com, kernelci@groups.io, "kernelci.org bot" , Shuah Khan References: <20220214184109.3739179-1-usama.anjum@collabora.com> <20220214184109.3739179-2-usama.anjum@collabora.com> From: Shuah Khan Message-ID: <8f62537f-e191-1d60-530a-9eb9c31b0511@linuxfoundation.org> Date: Mon, 14 Feb 2022 13:59:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220214184109.3739179-2-usama.anjum@collabora.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/14/22 11:41 AM, Muhammad Usama Anjum wrote: > Add check to test if CC has a string. CC can have multiple sub-strings > like "ccache gcc". Erorr pops up if it is treated as single string and > double quotes are used around it. This can be fixed by removing the > quotes and not treating CC as a single string. > > Fixes: e9886ace222e ("selftests, x86: Rework x86 target architecture detection") > Reported-by: "kernelci.org bot" > Signed-off-by: Muhammad Usama Anjum > --- > Changes in V2: > Update if condition to check if CC has a string > --- > tools/testing/selftests/x86/check_cc.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/x86/check_cc.sh b/tools/testing/selftests/x86/check_cc.sh > index 3e2089c8cf549..8c669c0d662ee 100755 > --- a/tools/testing/selftests/x86/check_cc.sh > +++ b/tools/testing/selftests/x86/check_cc.sh > @@ -7,7 +7,7 @@ CC="$1" > TESTPROG="$2" > shift 2 > > -if "$CC" -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then > +if [ -n "$CC" ] && $CC -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then > echo 1 > else > echo 0 > Looks good to me. Reviewed-by: Shuah Khan thanks, -- Shuah