From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B978C4BA34 for ; Thu, 27 Feb 2020 00:08:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CC6424679 for ; Thu, 27 Feb 2020 00:08:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728097AbgB0AIJ (ORCPT ); Wed, 26 Feb 2020 19:08:09 -0500 Received: from foss.arm.com ([217.140.110.172]:43934 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728012AbgB0AII (ORCPT ); Wed, 26 Feb 2020 19:08:08 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 663A61FB; Wed, 26 Feb 2020 16:08:08 -0800 (PST) Received: from [192.168.0.129] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DF9483F73B; Wed, 26 Feb 2020 16:08:06 -0800 (PST) Subject: Re: [PATCH 3/3] mm/vma: Make is_vma_temporary_stack() available for general use To: Vlastimil Babka , linux-mm@kvack.org Cc: Andrew Morton , linux-kernel@vger.kernel.org References: <1582692658-3294-1-git-send-email-anshuman.khandual@arm.com> <1582692658-3294-4-git-send-email-anshuman.khandual@arm.com> From: Anshuman Khandual Message-ID: <8f65781d-1ef0-8314-2baf-586b57a42e9c@arm.com> Date: Thu, 27 Feb 2020 05:38:07 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/26/2020 07:33 PM, Vlastimil Babka wrote: > On 2/26/20 5:50 AM, Anshuman Khandual wrote: >> Currently the declaration and definition for is_vma_temporary_stack() are >> scattered. Lets make is_vma_temporary_stack() helper available for general >> use and also drop the declaration from (include/linux/huge_mm.h) which is >> no longer required. This should not cause any functional change. >> >> Cc: Andrew Morton >> Cc: linux-kernel@vger.kernel.org >> Cc: linux-mm@kvack.org >> Signed-off-by: Anshuman Khandual > > The move made it plainly visible that the is_vma_* name differs from all the > other vma_is_* names. So this is a good chance to unify it? Yes, we can unify it while moving. Will change.