mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Georg Gottleuber <ggo@tuxedocomputers.com>
To: Christoph Hellwig <hch@lst.de>, Werner Sembach <wse@tuxedocomputers.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Sagi Grimberg <sagi@grimberg.me>,
	Georg Gottleuber <ggo@tuxedocomputers.com>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	Christoffer Sandberg <cs@tuxedocomputers.com>
Subject: Re: [PATCH] nvme-pci: Add TUXEDO IBS Gen8 to Samsung sleep quirk
Date: Thu, 3 Jul 2025 14:58:29 +0200	[thread overview]
Message-ID: <8f692b80-1015-4c9c-ba94-eda9afb919da@tuxedocomputers.com> (raw)
In-Reply-To: <20250703114557.GD17686@lst.de>


Am 03.07.25 um 13:45 schrieb Christoph Hellwig:
> On Tue, Jul 01, 2025 at 10:55:49PM +0200, Werner Sembach wrote:
>> From: Georg Gottleuber <ggo@tuxedocomputers.com>
>> 
>> On the TUXEDO InfinityBook S Gen8, a Samsung 990 Evo NVMe leads
>> to a high power consumption in s2idle sleep (3.5 watts).
>> 
>> This patch applies 'Force No Simple Suspend' quirk to achieve a 
>> sleep with a lower power consumption, typically around 1 watts.
> 
> Why do we keep getting more and more of these quirks instead of 
> getting the issue root caused and fixed?
> 

Hi, it is not a new quirk but another device. For me the real question
is: Why is NVME_QUIRK_SIMPLE_SUSPEND apparently used for nearly all
NVMes. This is no longer a quirk, but rather the new default.

For some device combinations, it just works better without this quirk.
That's why I set NVME_QUIRK_FORCE_NO_SIMPLE_SUSPEND.

Best regards,
Georg

  reply	other threads:[~2025-07-03 12:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-01 20:55 Werner Sembach
2025-07-03 11:45 ` Christoph Hellwig
2025-07-03 12:58   ` Georg Gottleuber [this message]
2025-08-25 16:07 ` Werner Sembach
2025-09-16 16:49   ` Werner Sembach
2025-09-16 18:16 ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f692b80-1015-4c9c-ba94-eda9afb919da@tuxedocomputers.com \
    --to=ggo@tuxedocomputers.com \
    --cc=axboe@kernel.dk \
    --cc=cs@tuxedocomputers.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=wse@tuxedocomputers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®