From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69CE8EB64DA for ; Thu, 22 Jun 2023 18:42:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230143AbjFVSmd (ORCPT ); Thu, 22 Jun 2023 14:42:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229986AbjFVSmb (ORCPT ); Thu, 22 Jun 2023 14:42:31 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DE761FFC for ; Thu, 22 Jun 2023 11:42:29 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2b4619ef079so96142021fa.2 for ; Thu, 22 Jun 2023 11:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687459347; x=1690051347; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Sjj3Boe/HdR5zbtRo/fyylNooQOkgRfrOTZ9rBEe6Bw=; b=Omoq/Psf65h/J0Xnd36qTxSaAMzihoVX/9b2fJWYcum0UPoYymXDz9mk2wwEn3JoeH npYR9qKvLoLqWY+v04GFXG6qQpqSSqsXjaNNn30xs72VpDbWu7zfPgmDXz5IQ3PK43Hj uJp2yFqObG1CTXIMjfBAERVKUiv7s0BA65tuRw0YHtwAPaFYEp8TXUyUNWnaXVMNKHzH GehQdO/5+9qOCBbHQVn3r/l8WmH5mA3OfbRL84GMJYZBkAsHW058IO+TZiZwIjC0tak0 IKA/ioe6NICNoL9aFuVYJeCoreNHdQkopgWShydzeuGxOqXf6EloNkLRTi8tI2pIPzz4 U78A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687459347; x=1690051347; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Sjj3Boe/HdR5zbtRo/fyylNooQOkgRfrOTZ9rBEe6Bw=; b=Ep/KCuU3P9SgY3zyfUqKpZgggI3rRclLvD4kfkWajG9VG6mvc9Qbgvk1oiVL9v4OsK 0BOngfhXDJKq+R0+ghcmcQGFNCHNGwAGAXCfwGYTndOZzQsp0mXXYDHTnHidkMGb6b8Y Qv4IULfVtweT3uRafenAKHkTOzr6b7znenkjQCaMJPLA74B2yXrebs2lrPbwLb9laElX SqMUQvUp+cRvaItLXPGog7gCPL70IapMgi2xLPy+zjJCyK7rGifyYKzY60DrUZeWKxIg +ja2HQjHIj95GqfwqV7JmlgcoJnoOq4d1c+PT7agrt+Fwtp0DKIXo+iP8LS5o0BhAKQS oOKg== X-Gm-Message-State: AC+VfDxFLjQh8ZaaY+aULgFLOu+XBV9wpFq/rIup/esPyFXeHLqRP2Ro 4//TrfPrwlyHbzj1IsvOp5eibg== X-Google-Smtp-Source: ACHHUZ45fBGVA7hhjEz9ruDoM5N1Xdmlgj5bRXIJecI+q+YtDZCQzJGfn3VzZPrqrZJ/dHgobkjzTg== X-Received: by 2002:a2e:9f56:0:b0:2b4:45bd:fd7 with SMTP id v22-20020a2e9f56000000b002b445bd0fd7mr11840621ljk.50.1687459347539; Thu, 22 Jun 2023 11:42:27 -0700 (PDT) Received: from [10.2.145.31] ([193.65.47.217]) by smtp.gmail.com with ESMTPSA id e17-20020a2e9851000000b002b331e241edsm1427299ljj.133.2023.06.22.11.42.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jun 2023 11:42:26 -0700 (PDT) Message-ID: <8f69cb15-6c70-031c-7632-15daddaddce2@linaro.org> Date: Thu, 22 Jun 2023 21:42:26 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 2/2] drm/msm/dsi: Enable runtime PM Content-Language: en-GB To: Konrad Dybcio , Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20230620-topic-dsiphy_rpm-v2-0-a11a751f34f0@linaro.org> <20230620-topic-dsiphy_rpm-v2-2-a11a751f34f0@linaro.org> From: Dmitry Baryshkov In-Reply-To: <20230620-topic-dsiphy_rpm-v2-2-a11a751f34f0@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/06/2023 14:43, Konrad Dybcio wrote: > Some devices power the DSI PHY/PLL through a power rail that we model > as a GENPD. Enable runtime PM to make it suspendable. > > Signed-off-by: Konrad Dybcio So, we were calling pm_runtime_get/put, but we didn't have runtime PM enabled for this device? It might be a nice place for dev_warn() in the driver core. Nevertheless: Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > index 2f319e0eb74f..22431e106529 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > @@ -689,6 +689,10 @@ static int dsi_phy_driver_probe(struct platform_device *pdev) > return dev_err_probe(dev, PTR_ERR(phy->ahb_clk), > "Unable to get ahb clk\n"); > > + ret = devm_pm_runtime_enable(&pdev->dev); > + if (ret) > + return ret; > + > /* PLL init will call into clk_register which requires > * register access, so we need to enable power and ahb clock. > */ > -- With best wishes Dmitry