From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751731AbdCCGyY (ORCPT ); Fri, 3 Mar 2017 01:54:24 -0500 Received: from regular1.263xmail.com ([211.150.99.131]:47935 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751530AbdCCGxx (ORCPT ); Fri, 3 Mar 2017 01:53:53 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: daniel.meng@rock-chips.com X-FST-TO: frank.wang@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: daniel.meng@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 2/3] Documentation: bindings: add DT documentation for u2phy and u2phy grf To: Rob Herring References: <1488440945-27291-1-git-send-email-daniel.meng@rock-chips.com> <1488440945-27291-3-git-send-email-daniel.meng@rock-chips.com> <20170303062156.cofjy6sndxz3gch5@rob-hp-laptop> Cc: mark.rutland@arm.com, geert+renesas@glider.be, yoshihiro.shimoda.uh@renesas.com, martin.blumenstingl@googlemail.com, devicetree@vger.kernel.org, kishon@ti.com, linux-kernel@vger.kernel.org, heiko@sntech.de, linux-usb@vger.kernel.org, linux-rockchip@lists.infradead.org, huangtao@rock-chips.com, kever.yang@rock-chips.com, william.wu@rock-chips.com, frank.wang@rock-chips.com From: "rock-chips(daniel.meng)" Message-ID: <8f6e3996-4988-b3b6-c18f-4d840aaa7955@rock-chips.com> Date: Fri, 3 Mar 2017 14:53:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170303062156.cofjy6sndxz3gch5@rob-hp-laptop> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/3/3 14:21, Rob Herring wrote: > On Thu, Mar 02, 2017 at 03:49:04PM +0800, Meng Dongyang wrote: >> Due to the u2phy registers are separated from general grf, we need to >> add u2phy grf node and place u2phy node in it. So this patch add u2phy >> grf node. > Similar comment on the subject. > >> Changes in v2: >> - add u2phy grf specification >> >> Signed-off-by: Meng Dongyang >> --- >> Documentation/devicetree/bindings/soc/rockchip/grf.txt | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.txt b/Documentation/devicetree/bindings/soc/rockchip/grf.txt >> index 013e71a..6ac23f9 100644 >> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.txt >> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.txt >> @@ -7,6 +7,9 @@ From RK3368 SoCs, the GRF is divided into two sections, >> - GRF, used for general non-secure system, >> - PMUGRF, used for always on system >> >> +On RK3328 SoCs, the GRF is divided into three sections, >> +except GRF and PMUGRF, add a section for USB2PHYGRF, >> + >> Required Properties: >> >> - compatible: GRF should be one of the followings >> @@ -19,6 +22,8 @@ Required Properties: >> - compatible: PMUGRF should be one of the followings >> - "rockchip,rk3368-pmugrf", "syscon": for rk3368 >> - "rockchip,rk3399-pmugrf", "syscon": for rk3399 >> +- compatible: USB2GRF should be one of the followings >> + - "rockchip,rk3328-usb2phy-grf", "syscon": for rk3328 >> - reg: physical base address of the controller and length of memory mapped >> region. >> >> @@ -33,3 +38,13 @@ Example: GRF and PMUGRF of RK3399 SoCs >> compatible = "rockchip,rk3399-grf", "syscon"; >> reg = <0x0 0xff770000 0x0 0x10000>; >> }; >> + >> +Example: USB2GRF of RK3328 SoCs >> + >> + usb2phy_grf: syscon@ff450000 { >> + compatible = "rockchip,rk3328-usb2phy-grf", "syscon", >> + "simple-mfd"; > simple-mfd is not documented. Do you have child nodes? do you mean we need to add a child node of phy here? > > What makes this a syscon? It has non-PHY registers? rk3328 devides grf into three parts and we put all u2phy registers into the part of u2phy grf, so here we add a simple usb2phy_grf. > > >> + reg = <0x0 0xff450000 0x0 0x10000>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + }; >> -- >> 1.9.1 >> >> > >