From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C4E5C433DB for ; Wed, 27 Jan 2021 19:40:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A39964D9E for ; Wed, 27 Jan 2021 19:40:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344507AbhA0Tj7 (ORCPT ); Wed, 27 Jan 2021 14:39:59 -0500 Received: from foss.arm.com ([217.140.110.172]:34058 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344566AbhA0ThV (ORCPT ); Wed, 27 Jan 2021 14:37:21 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 95AF5106F; Wed, 27 Jan 2021 11:36:34 -0800 (PST) Received: from [10.57.47.135] (unknown [10.57.47.135]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C789B3F68F; Wed, 27 Jan 2021 11:36:31 -0800 (PST) Subject: Re: [PATCH v2] of/device: Update dma_range_map only when dev has valid dma-ranges To: Rob Herring Cc: Frank Rowand , Christoph Hellwig , Marek Szyprowski , Joerg Roedel , Matthias Brugger , Will Deacon , Krzysztof Kozlowski , Tomasz Figa , "moderated list:ARM/Mediatek SoC support" , srv_heupstream , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-arm-kernel , Linux IOMMU , Nicolas Boichat , Yong Wu , Paul Kocialkowski References: <20210119105203.15530-1-yong.wu@mediatek.com> <159d4486-bb7e-249d-2bad-f5bba839041d@arm.com> From: Robin Murphy Message-ID: <8f742f94-4087-7fb6-4b7c-9058593b67cf@arm.com> Date: Wed, 27 Jan 2021 19:36:30 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-01-27 19:09, Rob Herring wrote: > On Wed, Jan 27, 2021 at 7:13 AM Robin Murphy wrote: >> >> [ + Christoph, Marek ] >> >> On 2021-01-27 13:00, Paul Kocialkowski wrote: >>> Hi, >>> >>> On Tue 19 Jan 21, 18:52, Yong Wu wrote: >>>> The commit e0d072782c73 ("dma-mapping: introduce DMA range map, >>>> supplanting dma_pfn_offset") always update dma_range_map even though it was >>>> already set, like in the sunxi_mbus driver. the issue is reported at [1]. >>>> This patch avoid this(Updating it only when dev has valid dma-ranges). >>>> >>>> Meanwhile, dma_range_map contains the devices' dma_ranges information, >>>> This patch moves dma_range_map before of_iommu_configure. The iommu >>>> driver may need to know the dma_address requirements of its iommu >>>> consumer devices. >>> >>> Just a gentle ping on this issue, it would be nice to have this fix merged >>> ASAP, in the next RC :) >> >> Ack to that - Rob, Frank, do you want to take this through the OF tree, >> or shall we take it through the DMA-mapping tree like the original culprit? > > I've already got some fixes queued up and can take it. Brilliant, thanks! > Suggested-by doesn't mean you are happy with the implementation. So > Acked-by or Reviewed-by? It still feels slightly awkward to give a tag to say "yes, this is exactly what I suggested", but for the avoidance of doubt, Reviewed-by: Robin Murphy Cheers, Robin.