Re: [PATCH 1/2] dt-bindings: misc: atmel,at91-ssc: Convert to YAML format

[Krzysztof Kozlowski <krzk@kernel.org>]

On 29/01/2025 14:28, Andrei Simion wrote:
> Hi,
> 
> Thank you for the review.
> 
> I will place this in: Documentation/devicetree/bindings/sound/
> because the SSC it is used only for Audio.
> 
>>
>> Missing dai-cells. Old binding said 0, now you say anything...
>>
>> Missing required block

Here, look.

>>
>>> +allOf:
>>> +  - $ref: ../sound/dai-common.yaml#
>>
>> Full path, so /schemas/
>>
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            enum:
>>> +              - atmel,at91sam9g45-ssc
>>> +    then:
>>> +      required:
>>> +        - compatible
>>> +        - reg
>>> +        - interrupts
>>> +        - dmas
>>> +        - dma-names
>>
>> So only dmas?
>>
>>> +        - clocks
>>> +        - clock-names
>>> +    else:
>>> +      required:
>>> +        - compatible
>>> +        - reg
>>> +        - interrupts
>>> +        - clocks
>>> +        - clock-names
>>
>> Drop entire required:
>>
> 
> I have a question:
> 
> 1) The old binding said if "atmel,at91sam9g45-ssc": add dmas and DMA-names to the list:
> 	- compatible, reg, interrupts, clock-names, clocks
>    Why do you ask: "drop entire required"?
>    I intended to set the required through a conditional.
>     case 1) dma transfer
>     case 2) pdc transfer

I commented earlier on missing required block in top-level.

Best regards,
Krzysztof