From: Ross Stutterheim <ross.sweng@gmail.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
Ross Stutterheim <ross.stutterheim@garmin.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Mike Rapoport <rppt@kernel.org>,
Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH] arm[64]/memremap: fix arch_memremap_can_ram_remap()
Date: Mon, 14 Apr 2025 09:18:28 -0500 [thread overview]
Message-ID: <8f7a84af-444f-46a9-b518-4fb010b7fba0@gmail.com> (raw)
In-Reply-To: <Z_0SfqQHsKs3S1cn@arm.com>
On 4/14/25 08:49, Catalin Marinas wrote:
> Please cc the maintainers and the original contributor of the commit you
> are fixing, otherwise the patch may not be noticed.
Thanks for adding them on your reply. I will add to V2.
>> diff --git a/arch/arm64/mm/ioremap.c b/arch/arm64/mm/ioremap.c
>> index 10e246f11271..48c38c986b95 100644
>> --- a/arch/arm64/mm/ioremap.c
>> +++ b/arch/arm64/mm/ioremap.c
>> @@ -51,7 +51,5 @@ void __init early_ioremap_init(void)
>> bool arch_memremap_can_ram_remap(resource_size_t offset, size_t size,
>> unsigned long flags)
>> {
>> - unsigned long pfn = PHYS_PFN(offset);
>> -
>> - return pfn_is_map_memory(pfn);
>> + return pfn_is_map_memory(offset);
>
> This is already correct.
Will remove on V2.
--
Ross
next prev parent reply other threads:[~2025-04-14 14:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 13:32 Ross Stutterheim
2025-04-14 13:49 ` Catalin Marinas
2025-04-14 14:18 ` Ross Stutterheim [this message]
2025-04-14 14:21 ` [PATCH v2] arm/memremap: " Ross Stutterheim
2025-04-16 10:09 ` Catalin Marinas
2025-04-16 13:57 ` Ross Stutterheim
2025-04-16 15:48 ` Russell King (Oracle)
2025-04-16 22:54 ` Catalin Marinas
2025-04-19 7:04 ` Mike Rapoport
2025-04-16 11:13 ` Linus Walleij
2025-04-16 13:52 ` [PATCH v3] " Ross Stutterheim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f7a84af-444f-46a9-b518-4fb010b7fba0@gmail.com \
--to=ross.sweng@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ross.stutterheim@garmin.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®