From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACBDE20AF7C; Tue, 18 Mar 2025 14:24:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742307899; cv=none; b=WDZyo60lIZ/iQPi1AWDexmbxvNTi39TLerR/S/rzwTYpitmUYe8o4jMMBnjyYsjf2lGXlk8sET6pArO3F2y+yt6eNg82zoo0K+lgiCtziptS1gNmyVuf5fZkc2mxzMOxWmBFyoXJPh8xLEDP0i6mG+Q25gY0CRZYhJttADzkcQE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742307899; c=relaxed/simple; bh=0vWEOSgAWC2OK9GLXIOx42CXDAs4ETuJxHSdMv03wa0=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=uirUA007m2ygeaZb1mffWn0hphjAvT39S68UZZfw5aN7DhawXiwsdj3DiuEO64OQUIUHz3MjPds+x0PdFaQ1Rl8vpF3hTz/Tc+w1pu4erdG/W4nYYIncf6F77q9B9pUpEhFDym999/zC6bUTU4SFBAscI2mGr0lmeQkO8VL8LOM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=Yv/E3eUw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="Yv/E3eUw" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52I9kYPB021228; Tue, 18 Mar 2025 14:24:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ThU9IQRy4eqH0cT3srdF8lldlckVmWSkhvbZ1vu/0IA=; b=Yv/E3eUwmvVtIPHw atvGPnIPM+bG9DFcJ7Q9dfkw6zwZkpJMsEMkySD0VIkqbCLosx8E+AWsGJzEoXRu QUB2m/J149v4dESEREBn7tGABKWJVoxjs8txLAPsyImDKOQw87CpEyj7yIdwQ1Cx NjrKXYRnaawSsKcwg0MEisOL0C14sGPYQMnpxdNtpeV8S2aQxFHJCKx9AV+bYrJ8 XqSEURYXesh9aEwrz1wLNz5+0Ggws1mmqvB2URILj6zgxWq/XuHY9Z3Nd0PecdEV tpJSEWb1BGFXumCwasdhgoi4iC7qIYCGloZdCz5ZrgueSbrjtgLLt52N/fmYjNR/ nukTHA== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45d1x80ksj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Mar 2025 14:24:53 +0000 (GMT) Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 52IEOquH011684 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Mar 2025 14:24:52 GMT Received: from [10.216.0.149] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 18 Mar 2025 07:24:47 -0700 Message-ID: <8f7c1c08-6776-968c-530e-b640ded940b3@quicinc.com> Date: Tue, 18 Mar 2025 19:54:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 3/4] arm64: dts: qcom: sa8775p: add support for video node Content-Language: en-US To: Konrad Dybcio , Dikshita Agarwal , Abhinav Kumar , "Mauro Carvalho Chehab" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio CC: , , , References: <20250311-dtbinding-v1-0-5c807d33f7ae@quicinc.com> <20250311-dtbinding-v1-3-5c807d33f7ae@quicinc.com> <3ec71075-b1ef-4366-b595-80fe41cd1e13@oss.qualcomm.com> From: Vikash Garodia In-Reply-To: <3ec71075-b1ef-4366-b595-80fe41cd1e13@oss.qualcomm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 3cYOyg668_HaSOs1P1XioAW1WQ-brk_y X-Proofpoint-ORIG-GUID: 3cYOyg668_HaSOs1P1XioAW1WQ-brk_y X-Authority-Analysis: v=2.4 cv=Jem8rVKV c=1 sm=1 tr=0 ts=67d98235 cx=c_pps a=JYp8KDb2vCoCEuGobkYCKw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=COk6AnOGAAAA:8 a=HdOZ2FAD_XOJwypVLEMA:9 a=oBbwvKzCPJ49F153:21 a=QEXdDO2ut3YA:10 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-18_07,2025-03-17_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 malwarescore=0 adultscore=0 phishscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503180106 On 3/15/2025 7:13 PM, Konrad Dybcio wrote: > On 3/11/25 1:03 PM, Vikash Garodia wrote: >> Video node enables video on Qualcomm SA8775P platform. >> >> Signed-off-by: Vikash Garodia >> --- >> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 67 +++++++++++++++++++++++++++++++++++ >> 1 file changed, 67 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >> index 3394ae2d13003417a15e64c9e47833725ec779e6..09db8e2eb578f1cada0f4a15e3f844dc097bd46d 100644 >> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >> @@ -10,6 +10,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -3783,6 +3784,72 @@ llcc: system-cache-controller@9200000 { >> interrupts = ; >> }; >> >> + iris: video-codec@aa00000 { >> + compatible = "qcom,sa8775p-iris"; >> + >> + reg = <0 0x0aa00000 0 0xf0000>; >> + interrupts = ; >> + >> + power-domains = <&videocc VIDEO_CC_MVS0C_GDSC>, >> + <&videocc VIDEO_CC_MVS0_GDSC>, >> + <&rpmhpd SA8775P_MXC>, >> + <&rpmhpd SA8775P_MMCX>; >> + power-domain-names = "venus", >> + "vcodec0", >> + "mx", >> + "mmcx"; >> + operating-points-v2 = <&iris_opp_table>; >> + >> + clocks = <&gcc GCC_VIDEO_AXI0_CLK>, >> + <&videocc VIDEO_CC_MVS0C_CLK>, >> + <&videocc VIDEO_CC_MVS0_CLK>; >> + clock-names = "iface", >> + "core", >> + "vcodec0_core"; >> + >> + interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS >> + &config_noc SLAVE_VENUS_CFG QCOM_ICC_TAG_ALWAYS>, > > This path should use QCOM_ICC_TAG_ACTIVE_ONLY on both endpoints What is the advantage of "ALWAYS" vs "ACTIVE_ONLY". Thinking of a possibility of APSS power collapsed, while video hardware is processing a frame ? Regards, Vikash > >> + <&mmss_noc MASTER_VIDEO_P0 QCOM_ICC_TAG_ALWAYS >> + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; >> + interconnect-names = "cpu-cfg", >> + "video-mem"; >> + >> + firmware-name = "qcom/vpu/vpu30_p4_s6.mbn"; > > If it needs different firmware, I have my doubts over why 8550's data > would be fully reused. Are you sure everything in iris_platform_sm8550.c > applies? > >> + memory-region = <&pil_video_mem>; >> + >> + resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>; >> + reset-names = "bus"; >> + >> + iommus = <&apps_smmu 0x0880 0x0400>, >> + <&apps_smmu 0x0887 0x0400>; >> + dma-coherent; >> + >> + iris_opp_table: opp-table { >> + compatible = "operating-points-v2"; >> + >> + opp-366000000 { >> + opp-hz = /bits/ 64 <366000000>; >> + required-opps = <&rpmhpd_opp_svs_l1>, >> + <&rpmhpd_opp_svs_l1>; >> + }; > > Please add a newline between subsequent subnodes > > Konrad