From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D282218A6B0 for ; Sat, 30 Nov 2024 14:50:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732978259; cv=none; b=kcbn5q+z/bSPsU/iEpU6VFs1l6pQs0sgzuTOwft6Wq3jUbr2OudU5Pdw9nXx1NDsL/woIF3SkZAWIihCcqNtgCcr9qP8QWo2lTQ2lK+OJ9yxm69OXNAuEC2RcX8fHCMW7K+U7Jj6DuxhH6UcIs3efb2xZMbyLhnbkW4dGiFv7KM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732978259; c=relaxed/simple; bh=g/hrGFzEV/Dkzl6O8E46iJp4OFRWCk0AzJevr5dw2rI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Zo6sNntmhFLESiWtLtSFDjtjRy1e9x89CK6qHdElPYN6SMrZ4ZVST6UXT20aCo+qhv/LXZujDq03H17j0prvYL7dnb+ibxwiQAKEqEyKlRF7/f283KVf6HY/6OL/QCed/pK6UhoUqDC4IWd5cYN7y/bGJrDHypx/Z0/Bwj8wG6A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d5veZu+6; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d5veZu+6" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AUCT7Hl010307 for ; Sat, 30 Nov 2024 14:50:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lbkawYJKZ0W65LLkx/SxJZ94dz9Mg7lmfego3SiyG2s=; b=d5veZu+6iqukvNmO sHlsXqz9dKZrgJ6tnfP4YuH71PuRtn/DdopNNXACateNM35QsCUq9T0Zx94svX/u egwCnYoGITUBLYi7ZY9hY5MHGBQ1aNwZzXT/HMJOTKu7/613KIJn5y1q+B51KZ72 eV7jHnm5c//MiCvX9ZjMMUkyWkFMmhE/tG10he1LO5jjuOPemDPlvKpBG6pd4dwk /wKkptgsU4jjsGBtq3NptiAK4D3+l4gaX6QdSxtMZLrMn2pDKmWNS9b2We5LJdEI iFLhblWuHasln9U0Fwitczh4A0ac9zhOQ4KdOsIHgahiEsZN1jTqIFu9s/rZ58Yg qBEq4w== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 437u368uhv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 30 Nov 2024 14:50:56 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-46692fb862bso3662141cf.1 for ; Sat, 30 Nov 2024 06:50:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732978256; x=1733583056; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lbkawYJKZ0W65LLkx/SxJZ94dz9Mg7lmfego3SiyG2s=; b=qD9B2aaTGmPXQl7AG0k5KKv36X9cDWr6vjDLWErVAHclTbq1ZOdgp2KLOLyso0eonn dxBSnjSAeXwcyCNuPYHy/qAD9ZrRR7Cv8iB1P+gyDCYX6YhLtDNtR22oxvFD+rBpkjxf Pis1y69I6d6vcZt56C7FJYI2ogz/75bAxAJUGOirKJga5kSEmtkqonUetk4EttaEco7h 0MfAMRPpoHeBsYl81A3kxQOkR8M3SzJcK76rL4ZjGqEZ0CnELE3yeiX9oJcUsW7i4Alr lI+uMpL93/njk3BLyWjH2I252xPhHJV1iyXaKtfj+DbipbQeejF2d+a+kEA3PQlcA/Zb 5H+A== X-Forwarded-Encrypted: i=1; AJvYcCVZI8kPpSWbGDRFDj8Q9RtCu1FNg+bvjXFsa+q8z6qaKbYHl2BOx2HjUxX+69KLvEkwCY2YmIqsS9XWsUo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5jEPUIerCmR45eouqCigVyRBgi1VkATcHxuGpBvI3pepPEuwN t33ur1NQF4fypJGfQbFsm9GzFKhnxI48XyC22ocijOUSz8jDJ2I/ANv5eXxdUBdq/rrn0xxgqTp RL/leTweC+rlgTLWwrWPfKg91L/Aozh/J3X1qRv0L7i5/rbGg/ZCAgdoyav17k5g= X-Gm-Gg: ASbGnctYIKFNxNp9cbuwfu/kYw3xVPdxiHezKU+vR5O0WKjSH1N9DO9Dj8i79boooxo Q49mOKlsaiCtf6KQ99kNpr8gbW5X4ETnHCYjXiDLEsTSbRmXg1UJtNsfHUiCTvqYDd27ykwWw1R ys8FstBbFlgVXR3xRNsAODrXW9OfzPvhedffouNpz5dJxwVYeZV68A7Fao3VqeUWoHR1rIXkY4c zDZ1dxwNSziFS3FGZmiAqCEIR6NGiyNxjrThJDXjpgLP5VkAuMHfTGvX6Hv7TNWuCOxfFNGPlJI FfQCuTP5CC1XXWdFuQySwd0/jxxi9MU= X-Received: by 2002:a05:620a:4453:b0:7b1:4920:8006 with SMTP id af79cd13be357-7b67c443d8amr727911585a.11.1732978255814; Sat, 30 Nov 2024 06:50:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IFiB4DUXKdpTA1uG8iXDBUJCIlpV7Th0TiVQZnAUloKHKxBxGs8xM7J9+ZZPoDXrlla79sa2Q== X-Received: by 2002:a05:620a:4453:b0:7b1:4920:8006 with SMTP id af79cd13be357-7b67c443d8amr727909985a.11.1732978255388; Sat, 30 Nov 2024 06:50:55 -0800 (PST) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d097ebb778sm2986267a12.85.2024.11.30.06.50.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Nov 2024 06:50:54 -0800 (PST) Message-ID: <8f7c8c5d-6637-43b1-b8ba-1616e4db949f@oss.qualcomm.com> Date: Sat, 30 Nov 2024 15:50:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/4] arm64: dts: qcom: ipq6018: move mp5496 regulator out of soc dtsi To: Chukun Pan , Bjorn Andersson Cc: Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20241110140019.3426181-1-amadeus@jmu.edu.cn> <20241110140019.3426181-4-amadeus@jmu.edu.cn> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241110140019.3426181-4-amadeus@jmu.edu.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: LMwO9ts9ou4NwSrdqfZJHzqIwddG7EcU X-Proofpoint-ORIG-GUID: LMwO9ts9ou4NwSrdqfZJHzqIwddG7EcU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxscore=0 clxscore=1015 bulkscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 mlxlogscore=916 phishscore=0 suspectscore=0 spamscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2411300122 On 10.11.2024 3:00 PM, Chukun Pan wrote: > Some IPQ60xx SoCs don't come with the mp5496 pmic chip. The mp5496 > pmic was never part of the IPQ60xx SoC, it's optional, so we moved > it out of the soc dtsi. > > Signed-off-by: Chukun Pan > --- > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 2 +- > arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi | 35 ++++++++++++++++++++ > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 14 -------- > 3 files changed, 36 insertions(+), 15 deletions(-) > create mode 100644 arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi > > diff --git a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts > index f5f4827c0e17..9c69d3027b43 100644 > --- a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts > +++ b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts > @@ -7,7 +7,7 @@ > > /dts-v1/; > > -#include "ipq6018.dtsi" > +#include "ipq6018-mp5496.dtsi" > > / { > model = "Qualcomm Technologies, Inc. IPQ6018/AP-CP01-C1"; > diff --git a/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi b/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi > new file mode 100644 > index 000000000000..fe2152df69f4 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi > @@ -0,0 +1,35 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) > +/* > + * ipq6018-mp5496.dtsi describes common properties (e.g. regulators) that > + * apply to most devices that make use of the IPQ6018 SoC and MP5496 PMIC. > + */ It's good to retain the copyright notices if you extract data out a file lgtm otherwise Konrad