From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F1D33EA6C for ; Wed, 10 Jan 2024 06:52:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="edih1lT0" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-40e47dc8b0eso25361765e9.3 for ; Tue, 09 Jan 2024 22:52:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704869532; x=1705474332; darn=vger.kernel.org; h=content-transfer-encoding:content-disposition:mime-version :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=L22KO18sbXj/gCvC8sLlz2ecMZMQd6S3fGWWRO4JzMA=; b=edih1lT0G1LonWAtsoNRLbLkSisrknAtcL0fGo+8/b51BaXCIPrdEVy5pVMPmg4r03 fp/3hx0882tXy9NaEVFCoVeOp69MASsl7630zHiJZwQ5YEze7hvv4dpc1tTsV1r97klr hG385j7zVa3gjX7iQE3M7TMbWNsE1jRCKmRtqxKGL0boYWotOC2au1Ey9R5ZqU+zb/QF Ucl6gGKxasJmbxUbvaq/JBL+mZcHdn1tTiK5NwzXJS9ExX5sDhFDoi3dGCOAZc7kTbKc 8Wu5JlCnrcOMEMBiZlbAP/OlKoahD8KIN2SkINGUTWMHCwiM39DsAJRtO7ELn9qaYnn1 r2pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704869532; x=1705474332; h=content-transfer-encoding:content-disposition:mime-version :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L22KO18sbXj/gCvC8sLlz2ecMZMQd6S3fGWWRO4JzMA=; b=Cz3l7DfK4tNw9Xm2eCHFzVQt5OMvcoCJ9KHH+lp+ZAD5CuuqbYBGCgYUs8tKapIhi5 4rJUoFuwLunqQTrxiQhoKqg/3RqApM3TC0AXcKPzqroYsVQjgq/Enm4scatCFFtiBJIs JzQ1O/N4LB+eS8DJEwQGf48fSN3Y5dKdidCON1fdkyI8yx/ewOWBbRcCYyIe8E3mgxJU xCVxVC+Ul5zMVeFCs0CNhXwDnLUc9waaO3IgLspWQ+1AsjMZlvHsUVxka4gvVBbBzVjr n+7QX+4D5gg66Tsgz1KVVD8ofm7tl723Ij4EJZ9SWY9RhDEN7rMPcmFGKELv63zfSZa9 xBvQ== X-Gm-Message-State: AOJu0Yyw06rUOm1fyjMVojvJhO1m3C2Gvq6GB2MpUXiUYyHVEaNXmnE/ 7L7gOxztvFCFpNXbuigKc+eP74g4YLC7dBc5Cxm7Znkojd0= X-Google-Smtp-Source: AGHT+IE+1zaWSCHaJZPKuO/16YTtzNTgfW73/daw9bVm6mWi+T8KTtVZU8GI8MXd7YVH6iDcybfogQ== X-Received: by 2002:a05:600c:b94:b0:40d:8fd1:6111 with SMTP id fl20-20020a05600c0b9400b0040d8fd16111mr256548wmb.116.1704869532327; Tue, 09 Jan 2024 22:52:12 -0800 (PST) Received: from localhost ([102.140.209.237]) by smtp.gmail.com with ESMTPSA id hn3-20020a05600ca38300b0040e4a7a7ca3sm979068wmb.43.2024.01.09.22.52.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 22:52:11 -0800 (PST) Date: Wed, 10 Jan 2024 09:52:08 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Eric Biggers Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Mike Snitzer Subject: drivers/md/dm-integrity.c:521 sb_mac() error: __builtin_memcmp() 'actual_mac' too small (64 vs 448) Message-ID: <8f8bcc1a-005f-4477-8440-37558c61fa30@moroto.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 9f8413c4a66f2fb776d3dc3c9ed20bf435eb305e commit: 070bb43ab01e891db1b742d4ddd7291c7f8d7022 dm integrity: use crypto_shash_digest() in sb_mac() config: i386-randconfig-141-20240107 (https://download.01.org/0day-ci/archive/20240109/202401092335.ZFBXDPA1-lkp@intel.com/config) compiler: ClangBuiltLinux clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202401092335.ZFBXDPA1-lkp@intel.com/ New smatch warnings: drivers/md/dm-integrity.c:521 sb_mac() error: __builtin_memcmp() 'actual_mac' too small (64 vs 448) Old smatch warnings: drivers/md/dm-integrity.c:3607 dm_integrity_alloc_page_list() warn: Please consider using kvcalloc instead of kvmalloc_array drivers/md/dm-integrity.c:3641 dm_integrity_alloc_journal_scatterlist() warn: Please consider using kvcalloc instead of kvmalloc_array drivers/md/dm-integrity.c:3910 create_journal() warn: Please consider using kvcalloc instead of kvmalloc_array vim +/actual_mac +521 drivers/md/dm-integrity.c 09d85f8d8909ec Mikulas Patocka 2021-01-21 492 static int sb_mac(struct dm_integrity_c *ic, bool wr) 09d85f8d8909ec Mikulas Patocka 2021-01-21 493 { 09d85f8d8909ec Mikulas Patocka 2021-01-21 494 SHASH_DESC_ON_STACK(desc, ic->journal_mac); 09d85f8d8909ec Mikulas Patocka 2021-01-21 495 int r; 070bb43ab01e89 Eric Biggers 2023-10-28 496 unsigned int mac_size = crypto_shash_digestsize(ic->journal_mac); 070bb43ab01e89 Eric Biggers 2023-10-28 497 __u8 *sb = (__u8 *)ic->sb; 070bb43ab01e89 Eric Biggers 2023-10-28 498 __u8 *mac = sb + (1 << SECTOR_SHIFT) - mac_size; 09d85f8d8909ec Mikulas Patocka 2021-01-21 499 070bb43ab01e89 Eric Biggers 2023-10-28 500 if (sizeof(struct superblock) + mac_size > 1 << SECTOR_SHIFT) { This caps mac_size to 448. 09d85f8d8909ec Mikulas Patocka 2021-01-21 501 dm_integrity_io_error(ic, "digest is too long", -EINVAL); 09d85f8d8909ec Mikulas Patocka 2021-01-21 502 return -EINVAL; 09d85f8d8909ec Mikulas Patocka 2021-01-21 503 } 09d85f8d8909ec Mikulas Patocka 2021-01-21 504 09d85f8d8909ec Mikulas Patocka 2021-01-21 505 desc->tfm = ic->journal_mac; 09d85f8d8909ec Mikulas Patocka 2021-01-21 506 09d85f8d8909ec Mikulas Patocka 2021-01-21 507 if (likely(wr)) { 070bb43ab01e89 Eric Biggers 2023-10-28 508 r = crypto_shash_digest(desc, sb, mac - sb, mac); 09d85f8d8909ec Mikulas Patocka 2021-01-21 509 if (unlikely(r < 0)) { 070bb43ab01e89 Eric Biggers 2023-10-28 510 dm_integrity_io_error(ic, "crypto_shash_digest", r); 09d85f8d8909ec Mikulas Patocka 2021-01-21 511 return r; 09d85f8d8909ec Mikulas Patocka 2021-01-21 512 } 09d85f8d8909ec Mikulas Patocka 2021-01-21 513 } else { 070bb43ab01e89 Eric Biggers 2023-10-28 514 __u8 actual_mac[HASH_MAX_DIGESTSIZE]; 0ef0b4717aa684 Heinz Mauelshagen 2023-02-01 515 070bb43ab01e89 Eric Biggers 2023-10-28 516 r = crypto_shash_digest(desc, sb, mac - sb, actual_mac); 09d85f8d8909ec Mikulas Patocka 2021-01-21 517 if (unlikely(r < 0)) { 070bb43ab01e89 Eric Biggers 2023-10-28 518 dm_integrity_io_error(ic, "crypto_shash_digest", r); 09d85f8d8909ec Mikulas Patocka 2021-01-21 519 return r; 09d85f8d8909ec Mikulas Patocka 2021-01-21 520 } 070bb43ab01e89 Eric Biggers 2023-10-28 @521 if (memcmp(mac, actual_mac, mac_size)) { But if it's more than 64 then it's a read overflow. 09d85f8d8909ec Mikulas Patocka 2021-01-21 522 dm_integrity_io_error(ic, "superblock mac", -EILSEQ); 82bb85998cc9a3 Michael Weiß 2021-09-04 523 dm_audit_log_target(DM_MSG_PREFIX, "mac-superblock", ic->ti, 0); 09d85f8d8909ec Mikulas Patocka 2021-01-21 524 return -EILSEQ; 09d85f8d8909ec Mikulas Patocka 2021-01-21 525 } 09d85f8d8909ec Mikulas Patocka 2021-01-21 526 } 09d85f8d8909ec Mikulas Patocka 2021-01-21 527 09d85f8d8909ec Mikulas Patocka 2021-01-21 528 return 0; 09d85f8d8909ec Mikulas Patocka 2021-01-21 529 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki