From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32387C38142 for ; Mon, 23 Jan 2023 07:55:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231352AbjAWHzq (ORCPT ); Mon, 23 Jan 2023 02:55:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229817AbjAWHzp (ORCPT ); Mon, 23 Jan 2023 02:55:45 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AFB2F742 for ; Sun, 22 Jan 2023 23:55:44 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id k16so8282251wms.2 for ; Sun, 22 Jan 2023 23:55:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=dT78j5UOCaWZYJCpxnJWictAYXf8HkrCpdNMdQHd/CE=; b=cQkW8psAaHVWpbOa2/yejx5t/JpwGrl0BxOK9pa1djggsds/sFdmTewdm8oz8OPsmc Bo3J7XOtLQHDt9OgpXIWaojuLWU+IuXMAm4qqPRHbz3N22dNFQjPCTMYfm5aksqenB7p MzZEIUC6tXm169oxdV1HC9YgpUYoIf3DLj9QzLOahJVQn2MMMztPtNFemuWJ5W5PlzLK LvKdREb9BulGIWHdjW8YAljm0TH2jswsLqWwHJFrwUYdmWgx+Bp+FNS4esV3lbo1kK6e vjyhoEYMiKRWjeouPEq9SZ+kuyzx2dEocvBvfWIZgkSnZx1kJJ7qcukotMBjAp392IOT reag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dT78j5UOCaWZYJCpxnJWictAYXf8HkrCpdNMdQHd/CE=; b=ghtc0dH1ebnhURc9nTVAThP7y6vEc3b/h3ZkB+igodQKV9PJWZxQEYAh0y5NdC0oCK nuKionDrmHn1196ej+53QsLeapXQ5BfXiECKW712ELkpNeyeUevi5ltKsPculpmvtKqE 9eIaDIhoq21hA2Y1Gg7UCC0nmrQB2vi70oWzlBAe+g55CzvPb3p7P7zWYaeDooVPDSr3 TpJhbZpBJhW/6pItfSh6Jkyl9zXQEms5J03bYoe6ze3b2liIrz2/azcOCu/Qkk4peOPS J7RKe2WEOP5LQ7rBD7A1Afxp8zTGJjUbic/8wuPbSRghPp/lEb82sue62R5vZnK+OG9a DfOA== X-Gm-Message-State: AFqh2krNAX4xhznWMMHUcNzNf6cgNqsw33Z60GK7enQ5G7PJcSM49B9L r6fVwQFLx3eJWjiDObomY+U7Zg== X-Google-Smtp-Source: AMrXdXvgIiQjIDU7jVEscMzip4gNS+rSZWTzoHqTyAMVtWtZ3w5K3AVPbSus80KJ6jgzminRlEGIZg== X-Received: by 2002:a1c:f607:0:b0:3d3:5027:89a4 with SMTP id w7-20020a1cf607000000b003d3502789a4mr31099798wmc.7.1674460542782; Sun, 22 Jan 2023 23:55:42 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id o21-20020a05600c4fd500b003c6f8d30e40sm10942947wmq.31.2023.01.22.23.55.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Jan 2023 23:55:42 -0800 (PST) Message-ID: <8f9d6e07-6549-9b2e-a45b-f262b59bfe5f@linaro.org> Date: Mon, 23 Jan 2023 08:55:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v2] memory: renesas-rpc-if: Fix PHYCNT.STRTIM setting To: Wolfram Sang , linux-renesas-soc@vger.kernel.org, Prabhakar , Sergey Shtylyov , linux-kernel@vger.kernel.org References: <20230118104656.67706-1-wsa+renesas@sang-engineering.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/01/2023 07:58, Wolfram Sang wrote: > Hi Krzysztof, > >>> +static const struct soc_device_attribute rpcif_info_match[] = { >>> + { .soc_id = "r8a7795", .revision = "ES1.*", .data = &rpcif_info_r8a7795_es1 }, >>> + { .soc_id = "r8a7796", .revision = "ES1.*", .data = &rpcif_info_r8a7796_es1 }, >> >> Why do you need soc match? Can't this be inferred from device >> compatible? Maybe the device compatible is not specific enough? Devices >> should not be interested in which SoC they are running - it does not >> matter for them, because the device difference is in the device itself, >> not in the SoC (different SoCs come with different devices). > > I need it because of ".revision". This only applies to "ES1.*", > there are "ES2.*" and "ES3.*" around which have the same SoC number. > Also, there is usually no version numbering for the IP core. We need to > use this scheme in a number of other places already, sadly. I did not get whether this is runtime characteristics or it can be customized with compatible (just you did not do it)? Best regards, Krzysztof