mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <samcacc@amazon.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Alexander Graf <graf@amazon.com>,
	Sam Caccavale <samcacc@amazon.de>
Cc: <samcaccavale@gmail.com>, <nmanthey@amazon.de>,
	<wipawel@amazon.de>, <dwmw@amazon.co.uk>, <mpohlack@amazon.de>,
	<karahmed@amazon.de>, <andrew.cooper3@citrix.com>,
	<JBeulich@suse.com>, <rkrcmar@redhat.com>, <tglx@linutronix.de>,
	<mingo@redhat.com>, <bp@alien8.de>, <hpa@zytor.com>,
	<paullangton4@gmail.com>, <x86@kernel.org>, <kvm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/5] Added build and install scripts
Date: Fri, 28 Jun 2019 10:27:30 +0200	[thread overview]
Message-ID: <8f9e2dd8-f83f-0685-5939-33e77d97a6c6@amazon.com> (raw)
In-Reply-To: <4438c94e-a0ed-0e5c-0a74-02aed8949b24@redhat.com>

On 6/28/19 10:17 AM, Paolo Bonzini wrote:
> On 28/06/19 09:59, samcacc@amazon.com wrote:
>>> Surely if it's important to generate core dumps, it's not only important
>>> during installation, no?
>> Yep... missed this.  I'll move it to run.sh right before alf-many is
>> invoked.  It would be nice to not have to sudo but it seems the only
>> alternative is an envvar AFL_I_DONT_CARE_ABOUT_MISSING_CRASHES which
>> just ignores AFL's warning if your system isn't going to produce core
>> dumps (which will cause AFL to miss some crashes, as the name suggests).
> 
> Can you do this only if /proc/sys/kernel/core_pattern starts with a pipe
> sign?
> 

I think I'll just remove the `echo > ...core_pattern` step from both the
build.sh and run.sh scripts and instead document it as a setup step in
the README.  This also sidesteps the sudo use.

- Sam

> Thanks,
> 
> Paolo
> 


  reply	other threads:[~2019-06-28  8:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-24 14:24 [PATCH v3 0/5] x86 instruction emulator fuzzing Sam Caccavale
2019-06-24 14:24 ` [PATCH v3 1/5] Build target for emulate.o as a userspace binary Sam Caccavale
2019-06-24 14:24 ` [PATCH v3 2/5] Emulate simple x86 instructions in userspace Sam Caccavale
2019-06-24 14:24 ` [PATCH v3 3/5] Demonstrating unit testing via simple-harness Sam Caccavale
2019-06-24 14:24 ` [PATCH v3 4/5] Added build and install scripts Sam Caccavale
2019-06-27 16:57   ` Alexander Graf
2019-06-28  7:59     ` samcacc
2019-06-28  8:17       ` Paolo Bonzini
2019-06-28  8:27         ` samcacc [this message]
2019-06-24 14:24 ` [PATCH v3 5/5] Development scripts for crash triage and deploy Sam Caccavale

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f9e2dd8-f83f-0685-5939-33e77d97a6c6@amazon.com \
    --to=samcacc@amazon.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=bp@alien8.de \
    --cc=dwmw@amazon.co.uk \
    --cc=graf@amazon.com \
    --cc=hpa@zytor.com \
    --cc=karahmed@amazon.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mpohlack@amazon.de \
    --cc=nmanthey@amazon.de \
    --cc=paullangton4@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=samcacc@amazon.de \
    --cc=samcaccavale@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=wipawel@amazon.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®