mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@ozlabs.org>
To: Eddie James <eajames@linux.ibm.com>, linux-fsi@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org, alistair@popple.id.au, joel@jms.id.au
Subject: Re: [PATCH] fsi: Add aliased device numbering
Date: Fri, 27 Jan 2023 09:03:23 +0800	[thread overview]
Message-ID: <8fa108c9dedf884eab6dacaf3e9680b7c66c4202.camel@ozlabs.org> (raw)
In-Reply-To: <20230126223850.901302-1-eajames@linux.ibm.com>

Hi Eddie,

> The I2C and SPI subsystems can use an aliased name to number the
> device. Add similar support to the FSI subsystem for any device type.

Sounds good!

However, the majority of this patch seems to be the change to a (const)
enum value, which you then convert to a string to generate the
non-number component of the device name.

Does:

       dev_set_name(&scom->dev, "%s%d", fsi_get_dev_type_name(fsi_dev_scom), didx);

have much of a benefit over:

       dev_set_name(&scom->dev, "scom%d", didx);

?

Cheers,


Jeremy

  reply	other threads:[~2023-01-27  1:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26 22:38 Eddie James
2023-01-27  1:03 ` Jeremy Kerr [this message]
2023-01-27 14:40   ` Eddie James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fa108c9dedf884eab6dacaf3e9680b7c66c4202.camel@ozlabs.org \
    --to=jk@ozlabs.org \
    --cc=alistair@popple.id.au \
    --cc=eajames@linux.ibm.com \
    --cc=joel@jms.id.au \
    --cc=linux-fsi@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®