Re: [PATCH v5 3/9] ASoC: qcom: dt-bindings: qcom,lpass-va-macro: Update bindings for clocks to support ADSP

[Prasad Kumpatla <quic_pkumpatl@quicinc.com>]

On 6/25/2025 2:14 PM, Krzysztof Kozlowski wrote:
> On 25/06/2025 10:29, Prasad Kumpatla wrote:
>> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>>
>> Manage clock settings for ADSP solution.
>>
>> On Existing ADSP bypass solutions, The macro and dcodec GDSCs are
> 
> s/The/the/

Ack.

> 
> OK, this has to be expressed in schema - oneOf in top-level for presence
> (required) power domains or clocks (contains for these names).

Will check and update.

> 
> 
>> enabled using power domains in lpass-va-macro which is not applicable
>> for ADSP based platform.
>>
>> Reference:
>>   - qcom,lpass-tx-macro.yaml
>>   - qcom,lpass-rx-macro.yaml
> 
> I don't understand this reference.

Please refer below link for more info. Which is similar kind of 
properties used.

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/tree/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml#n72

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/tree/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml#n77

> 
>>
>> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>> ---
>>   .../bindings/sound/qcom,lpass-va-macro.yaml        | 14 ++++++++++----
>>   1 file changed, 10 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
>> index f41deaa6f4df..38679a4f21fa 100644
>> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
>> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
>> @@ -75,14 +75,20 @@ allOf:
>>           compatible:
>>             contains:
>>               const: qcom,sc7280-lpass-va-macro
>> +
> 
> Why? It's a different style now. Don't introduce random whitespace changes.

Ack.

Thanks,
Prasad

> 
> 
> Best regards,
> Krzysztof