mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Wei-chin Tsai (蔡維晉)" <Wei-chin.Tsai@mediatek.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Mel Lee (李奇錚)" <Mel.Lee@mediatek.com>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	wsd_upstream <wsd_upstream@mediatek.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"Ivan Tseng (曾志軒)" <ivan.tseng@mediatek.com>,
	"angelogioacchino.delregno@collabora.com"
	<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v1 1/1] process: export symbols for fork/exit tracing functions
Date: Tue, 13 Jun 2023 09:12:38 +0000	[thread overview]
Message-ID: <8fa623a77edd2d8b6ade77903d40b4c4c5992965.camel@mediatek.com> (raw)
In-Reply-To: <2023061226-repugnant-upstate-a2b4@gregkh>

On Mon, 2023-06-12 at 18:37 +0200, Greg Kroah-Hartman wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Mon, Jun 12, 2023 at 11:15:41PM +0800, jim.tsai wrote:
> > +static void class_create_release(struct class *cls)
> > +{
> > +/*do nothing because the mbraink class is not from malloc*/
> > +}
> 
> Then the code is totally broken and wrong :(
> 
> Please just use the misc device api instead, it is much simpler and
> doesn't have these types of errors.
> 
> thanks,
> 
> greg k-h


Sorry, I did not really get the point from above comments because It
works well for me for the mbraink_main.c and no compiler errors or
runtime errors?

thanks.

Jim

  reply	other threads:[~2023-06-13  9:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230612151545.17810-1-Wei-chin.Tsai@mediatek.com>
2023-06-12 16:35 ` Greg Kroah-Hartman
2023-06-12 16:35 ` Greg Kroah-Hartman
2023-06-12 16:37 ` Greg Kroah-Hartman
2023-06-13  9:12   ` Wei-chin Tsai (蔡維晉) [this message]
2023-06-13  9:18     ` gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fa623a77edd2d8b6ade77903d40b4c4c5992965.camel@mediatek.com \
    --to=wei-chin.tsai@mediatek.com \
    --cc=Mel.Lee@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=ivan.tseng@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=wsd_upstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®