From: Jiri Slaby <jirislaby@kernel.org>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Josh Triplett <josh@joshtriplett.org>,
Anders Blomdell <anders.blomdell@control.lth.se>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] serial: 8250: Let drivers request full 16550A feature probing
Date: Mon, 19 Sep 2022 06:42:22 +0200 [thread overview]
Message-ID: <8fa701a1-3f34-9152-daf6-1618dd0e7727@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2209171043270.31781@angie.orcam.me.uk>
On 17. 09. 22, 12:07, Maciej W. Rozycki wrote:
> --- linux-macro.orig/include/linux/serial_core.h
> +++ linux-macro/include/linux/serial_core.h
> @@ -414,7 +414,7 @@ struct uart_icount {
> __u32 buf_overrun;
> };
>
> -typedef unsigned int __bitwise upf_t;
> +typedef __u64 __bitwise upf_t;
Why __u64 and not u64?
> typedef unsigned int __bitwise upstat_t;
>
> struct uart_port {
> @@ -522,6 +522,7 @@ struct uart_port {
> #define UPF_FIXED_PORT ((__force upf_t) (1 << 29))
> #define UPF_DEAD ((__force upf_t) (1 << 30))
> #define UPF_IOREMAP ((__force upf_t) (1 << 31))
> +#define UPF_FULL_PROBE ((__force upf_t) (1ULL << 32))
This looks like a perfect time to switch them all to BIT_ULL().
thanks,
--
js
suse labs
next prev parent reply other threads:[~2022-09-19 4:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 10:07 [PATCH 0/2] " Maciej W. Rozycki
2022-09-17 10:07 ` [PATCH 1/2] " Maciej W. Rozycki
2022-09-19 4:42 ` Jiri Slaby [this message]
2022-09-19 8:18 ` Maciej W. Rozycki
2022-09-19 10:49 ` Jiri Slaby
2022-09-20 23:35 ` Maciej W. Rozycki
2022-09-17 10:07 ` [PATCH 2/2] serial: 8250: Request full 16550A feature probing for OxSemi PCIe devices Maciej W. Rozycki
2022-09-19 4:44 ` Jiri Slaby
2022-09-19 8:23 ` Maciej W. Rozycki
2022-09-20 23:35 ` Maciej W. Rozycki
2022-09-17 15:00 ` [PATCH 0/2] serial: 8250: Let drivers request full 16550A feature probing Josh Triplett
2022-09-18 8:26 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fa701a1-3f34-9152-daf6-1618dd0e7727@kernel.org \
--to=jirislaby@kernel.org \
--cc=anders.blomdell@control.lth.se \
--cc=gregkh@linuxfoundation.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome