From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B33FE2D94A0 for ; Wed, 11 Mar 2026 12:40:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773232813; cv=none; b=q+A14TTh9ty8LSUh2Sy0S1ThhkViLBYPiDFvyQXiylOKu1wr0VkEGEYKIsa+UDAhNoI11Wd1kA8Z9rVUwd1DkbRC0nzVsb/LySP7bVDPstlV9dlMPHhcudnj3VwLvs0RNYvVnJutcQYluuzamuy/vNAp/VDyZ1DwZPFSBVusFPY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773232813; c=relaxed/simple; bh=q1phuj9nSiqlXFs59n/SUidEu6KkKZUmRxu/IEaVcj8=; h=Message-ID:Date:MIME-Version:To:Cc:From:Subject:Content-Type; b=Ut9OS5KgyclaqCtUj41i5U/g0PRyfxXGv7Kn3lL6jmaFEm9Gvbm9dkrh9xqxTk8EW3RSYY5Vez5+NecgPgyPxD1Qn1U/9rS4J8rFaHriunhRQWc0RF2ifXbW5/iV/SugbgKspPw7v9kz5f+uICQ61+0S3WZqGn8I2puyyCslIIQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JddLbFz/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=keu9OWZo; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JddLbFz/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="keu9OWZo" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62BBoGgt1439645 for ; Wed, 11 Mar 2026 12:40:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=hYqck+gSoswXIm7KvNxr8d aYoISybhT0tfxsMu+V4hE=; b=JddLbFz/8RRlopHJoleSOh11tNKXHR3II7IH0Q B6s7QiovXEbjX517YuRHqalK+k1si59Xh8S2CcUX2X/dipRmHx0tIp9+jRzLbt+l ckwUO93kzMzzaWVe1u1EyD8RJh/oiULFhRJtjj+c0j3G0SzntplQc9NxfOPafMt6 9gSS1kMIyeEbPDz6XODhFU15jNMq0uPJ+i9WMmQ0JuZ2DQQitMGO3SHRU5KOdAuI KItFcnIS6X5rPjwVRR4XREZccWvTny/BWApMQzJBbltULk8bFRVoqL2EkkVClxkm SoEoGT079unofQ0de85ucFKvl9u18Hlcl59FHgZX3piQGiHA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cu38yhanv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 12:40:11 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cd7a2c535eso90155085a.3 for ; Wed, 11 Mar 2026 05:40:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773232811; x=1773837611; darn=vger.kernel.org; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=hYqck+gSoswXIm7KvNxr8daYoISybhT0tfxsMu+V4hE=; b=keu9OWZoX8d6pE5FgmI1eyImsys67HFT+j02nWo05FPDxBoRz6qEfHGOLizvCQsjDM zK7cWznBxR8e7GmVrylphcHugA8hs4RbNtzk02rkFIB0i5XgaEjFA5DkHX2nZmRAbT51 IDcaHRMqJH8cbKJdhEvlrExs5kSlNVlNELoAbOOYpaStk9QO3/iIUviolp18fJq5fBoZ LbnlvECrp94IwUg/ONN8FAgSqJvqw+D/yZVVpll3W+SgtY7UKkAWGNsXasiJmKQkfXUF KrdwVwGIlxijSlRr23KWKGLnFpWCT2ZhV/0yQIq/6lvGuHxtsnqTZPJEWBlvb+KCpzni 1RCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773232811; x=1773837611; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hYqck+gSoswXIm7KvNxr8daYoISybhT0tfxsMu+V4hE=; b=Z83s/vM+6Ppd+L54gzTu4hqXAVi+2pU5Z7/Z/mIXhtQSUI16NhB/8Qmd7FTEuLPfXc SRgIDVQVCE61hjFn5mThrn/RBKHzi9eaeXXT4AIhkYvoCCMtSjJm4/I8JEMGEoDAoAm7 pTW708cICVfZx+jE0iNTgx/S04a2jcLlW3I7tkVANpw8NZ8NOjfbX/kIygMSIjyy41oH O+bGAYSKRLHftUH1C7bX0G8zuZFLNfppFx6PS/Ijj/mxrBr6EZT6BHv1T964qjWF8VJw cADTDTO23r2DATHhi0KLxI4SRDISCGrJ5IKn8W9p3Kw9YIUgf1firRSOSD2t2HPHP0rO jQBw== X-Forwarded-Encrypted: i=1; AJvYcCVFeTDrSwxsemuJqnoy1a3PsFBTnAinPpbmQ6pbC4W57uly9Lr0wIX4k0d5w9xWxv/IPzB6mhDGRwVYrpY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzn93LTWavXpvNzJEj4dmnozD9SIb4ULp7iMmWEaaF5UV7KETTD W67rgQcXMGpEXWrEbq4BlsYMKJMHaESpwKPGSDZ4CikBDyfWoqpNWFhS9NTd2z0lTyhsDVd35Xj q4tc9so0oQ6wTw1uGBB4g0TVvX9wHJJXsQJISNaCuRPnEwtZnUndp/tW71N3aek5YbSWzUhr69T Y= X-Gm-Gg: ATEYQzzu+YYgfTcTk1jl3Eo6VT3sj3v9aye1Jiw9NJ/uaJEQ28ZdppwoaEDNANZZx2V dbiFB/Ox5Xj5REvB3MvZLqlZNMEOfqNP2EK1IHumRYarEsFXBoElpA2+yQ1PTtrIzA5TVllIbvh 7Og6GiGJrUQg/Z0zPOJfwHb6X79Tbl70V6DZVWtUd8FwHjzn3sAlhSdGhekWuxvf6ocQahdUHBA BHb8T2nNYmB/SAlgG0WqFXE/PrR15anPHO1S7h5s/ZTb0SzJ7PLFF7YcO13VeEWsb/Q0XarhgKq IiM9lCR/HNpkGN3VPaFbqcUJHRVjPDNEArf3vFnHllHXC6AOMnZc8FOOkMBxegyter/0tMyS0Lc 2Ubbs3bz8uZvwqL88rYPfLGkFjbL7/KQanzWyvvUk7LcQNr684NwlItxd1OCbQvFE0Lh4PCmsmz GDkP0= X-Received: by 2002:a05:620a:4707:b0:8c6:a719:d16f with SMTP id af79cd13be357-8cda194fb1emr240816385a.4.1773232810892; Wed, 11 Mar 2026 05:40:10 -0700 (PDT) X-Received: by 2002:a05:620a:4707:b0:8c6:a719:d16f with SMTP id af79cd13be357-8cda194fb1emr240812685a.4.1773232810252; Wed, 11 Mar 2026 05:40:10 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97313230desm40306266b.26.2026.03.11.05.40.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Mar 2026 05:40:09 -0700 (PDT) Message-ID: <8fabc049-7fdf-498a-a3ef-6f2570d510c8@oss.qualcomm.com> Date: Wed, 11 Mar 2026 13:40:06 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Baryshkov , Heikki Krogerus , Johan Hovold , Thinh Nguyen Cc: "linux-usb@vger.kernel.org" , dt , lkml , Wesley Cheng From: Konrad Dybcio Subject: grumpy DWC3+UCSI, usb-role-switch semantics Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDEwNyBTYWx0ZWRfXwkuovsmJ2hGv txZ+3jooykCfyggrqx3OiPeC/ZGt6Q4GiVNwu6YP3HBpk44Kg/PIc23QKf+iR1XhWsEg/bgvjzk 7FicJmkb/BFilg64Hm1OHJqAnYw5VSRw24HaUGIx70rpkgII9IXyKI92/GTt4NbonjRj7xvuO/w Kd35DGtjUEwxNCG1P70EqbHe770OBdMwBXiAQWkBcVEyZScEg47VWgVDVQaJ/vkh0XAKmcrPM2v ZWxE7yBSkpU/mwzFVLyYMqT3cZGVtMd3hMePjYT3GWHfY7OujGuPJJriIcT/1JHi3tYGh3C6/dz jooLvTrjnYl3bPN4bEYAzxPXBq4+StrSnbe+Xlq3winwNh/xo+DJzx7wv/QGrgzP2/+J6so1HYZ iWPSQbfwFXG6hUeg6MTcRpkMM5dtOv//sa+0Bo87JrQEXRsxX2wKMIMYQvGInUIvS8YJ9jTppuo ZCGVmf3np3RSyXKf1nQ== X-Proofpoint-GUID: 6nXocRZSnMY2_EgkJyTwe0A9nFkJlXyg X-Proofpoint-ORIG-GUID: 6nXocRZSnMY2_EgkJyTwe0A9nFkJlXyg X-Authority-Analysis: v=2.4 cv=Cq+ys34D c=1 sm=1 tr=0 ts=69b162ab cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=zitRP-D0AAAA:8 a=9NdRVNC825nQ0Wb3IxUA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=xwnAI6pc5liRhupp6brZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-11_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110107 Hi, The description for the usb-role-switch property (usb-drd.yaml) states: Indicates that the device is capable of assigning the USB data role (USB host or USB device) for a given USB connector, such as Type-C, Type-B(micro). See connector/usb-connector.yaml. That to me sounds like a description of the capability of the on-SoC controller (i.e. should/could be set regardless of device specifics), however in this configuration: &usb { dr_mode = "host"; usb-role-switch; }; the role switch device is never registered on devices with a DWC3 controller, since that's handled in dwc3_drd_init(), which is only called if dr_mode = "otg" (or absent since otg is the default). This notably causes: ucsi_init() -> ucsi_register_port() -> fwnode_usb_role_switch_get() to loop in -EPROBE_DEFER, since the 'usb-role-switch' property is present on the connected DWC3 core, but the rolesw device is never registered. Now, it seems like different drivers do this differently, e.g. DWC2 seems to always register a rolesw. How should we tackle this? FWIW I'd prefer (for maintainability reasons) to not have to set/remove 'usb-role-switch' separately for each board, depending on whether whatever is at the other end of the USB cables is rolesw-capable (since again, the controller itself is), but if we go that route, I'd request that we explicitly forbid the combination of usb-role-switch && dr_mode=host/peripheral in bindings, so that the computer yells at me if I overlook that Konrad P.S. this is the reason behind the issue we encountered at: https://lore.kernel.org/linux-arm-msm/Z1gbyXk-SktGjL6-@hovoldconsulting.com/