From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: "Dominik Karol Piątkowski"
<dominik.karol.piatkowski@protonmail.com>,
gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vt6655: rxtx.c: Fix too long lines in get_rtscts_time
Date: Wed, 18 Sep 2024 21:12:43 +0200 [thread overview]
Message-ID: <8faf5f05-8651-4601-a70f-7d417bbdee22@gmail.com> (raw)
In-Reply-To: <20240918165052.30386-1-dominik.karol.piatkowski@protonmail.com>
On 9/18/24 18:51, Dominik Karol Piątkowski wrote:
> This patch fixes the lines exceeding 100 columns in get_rtscts_time
> function.
>
> Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
> ---
> drivers/staging/vt6655/rxtx.c | 27 ++++++++++++++++++---------
> 1 file changed, 18 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> index 3705cb1e87b6..1ea17e86e3ee 100644
> --- a/drivers/staging/vt6655/rxtx.c
> +++ b/drivers/staging/vt6655/rxtx.c
> @@ -202,20 +202,29 @@ static __le16 get_rtscts_time(struct vnt_private *priv,
>
> data_time = bb_get_frame_time(priv->preamble_type, pkt_type, frame_length, current_rate);
> if (rts_rsvtype == 0) { /* RTSTxRrvTime_bb */
> - rts_time = bb_get_frame_time(priv->preamble_type, pkt_type, 20, priv->byTopCCKBasicRate);
> - ack_time = bb_get_frame_time(priv->preamble_type, pkt_type, 14, priv->byTopCCKBasicRate);
> + rts_time = bb_get_frame_time(priv->preamble_type, pkt_type, 20,
> + priv->byTopCCKBasicRate);
> + ack_time = bb_get_frame_time(priv->preamble_type, pkt_type, 14,
> + priv->byTopCCKBasicRate);
> cts_time = ack_time;
> } else if (rts_rsvtype == 1) { /* RTSTxRrvTime_ba, only in 2.4GHZ */
> - rts_time = bb_get_frame_time(priv->preamble_type, pkt_type, 20, priv->byTopCCKBasicRate);
> - cts_time = bb_get_frame_time(priv->preamble_type, pkt_type, 14, priv->byTopCCKBasicRate);
> - ack_time = bb_get_frame_time(priv->preamble_type, pkt_type, 14, priv->byTopOFDMBasicRate);
> + rts_time = bb_get_frame_time(priv->preamble_type, pkt_type, 20,
> + priv->byTopCCKBasicRate);
> + cts_time = bb_get_frame_time(priv->preamble_type, pkt_type, 14,
> + priv->byTopCCKBasicRate);
> + ack_time = bb_get_frame_time(priv->preamble_type, pkt_type, 14,
> + priv->byTopOFDMBasicRate);
> } else if (rts_rsvtype == 2) { /* RTSTxRrvTime_aa */
> - rts_time = bb_get_frame_time(priv->preamble_type, pkt_type, 20, priv->byTopOFDMBasicRate);
> - ack_time = bb_get_frame_time(priv->preamble_type, pkt_type, 14, priv->byTopOFDMBasicRate);
> + rts_time = bb_get_frame_time(priv->preamble_type, pkt_type, 20,
> + priv->byTopOFDMBasicRate);
> + ack_time = bb_get_frame_time(priv->preamble_type, pkt_type, 14,
> + priv->byTopOFDMBasicRate);
> cts_time = ack_time;
> } else if (rts_rsvtype == 3) { /* CTSTxRrvTime_ba, only in 2.4GHZ */
> - cts_time = bb_get_frame_time(priv->preamble_type, pkt_type, 14, priv->byTopCCKBasicRate);
> - ack_time = bb_get_frame_time(priv->preamble_type, pkt_type, 14, priv->byTopOFDMBasicRate);
> + cts_time = bb_get_frame_time(priv->preamble_type, pkt_type, 14,
> + priv->byTopCCKBasicRate);
> + ack_time = bb_get_frame_time(priv->preamble_type, pkt_type, 14,
> + priv->byTopOFDMBasicRate);
> rrv_time = cts_time + ack_time + data_time + 2 * priv->uSIFS;
> return cpu_to_le16((u16)rrv_time);
> }
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
prev parent reply other threads:[~2024-09-18 19:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 16:51 Dominik Karol Piątkowski
2024-09-18 19:12 ` Philipp Hortmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8faf5f05-8651-4601-a70f-7d417bbdee22@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=dominik.karol.piatkowski@protonmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®