From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 446EB14F9D9; Mon, 30 Sep 2024 19:39:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727725166; cv=none; b=QUlv9DFdY6kBawHreSBknwyDXtby5mFoIatlebmcQlwWb4MKGRRzuP5Y+kzsax/7idyTkSOPCGaDgwC8S1rVidmgZO253FzgI/EMAVhwyda+AN4iMD1R6DFP10XWtLK752erhOTKvmEbPfXvNPEo4jjRwQ8UUUygW1PZFisFJME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727725166; c=relaxed/simple; bh=27szOiLQT71Gl3SyJZ5fwkkmSWNtmky6vqDpgZEOPeE=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=njyz4hG7UyglVSQpaVWC3cMprMdYXaYP/2AbdytgrN1PyfE8aFkZ9F8HOBKPfLx0HH8i6BvBu5YabeZjEdfJXriGCzgELg+0YnyrdyOwrS7lF8yxp0T9EkEHljmxvuyiD94dXeznnyrXpaRbpFUkqQV1KoWmDDKa5mHmBrXiWss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from [192.168.2.100] (213.87.154.82) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Mon, 30 Sep 2024 22:39:12 +0300 Message-ID: <8fb6f818-e818-4ba2-b1a9-e4468d4496aa@omp.ru> Date: Mon, 30 Sep 2024 22:39:11 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net-next PATCH 07/11] net: ravb: Simplify UDP TX checksum offload To: Paul Barker , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni CC: Paul Barker , Geert Uytterhoeven , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Biju Das , Claudiu Beznea , , , References: <20240930160845.8520-1-paul@pbarker.dev> <20240930160845.8520-8-paul@pbarker.dev> Content-Language: en-US From: Sergey Shtylyov Organization: Open Mobile Platform In-Reply-To: <20240930160845.8520-8-paul@pbarker.dev> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 09/30/2024 19:25:52 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 19 X-KSE-AntiSpam-Info: Lua profiles 188102 [Sep 30 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.4 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 35 0.3.35 d90443ea3cdf6e421a9ef5a0a400f1251229ba23 X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 213.87.154.82 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;omp.ru:7.1.1;127.0.0.199:7.1.2 X-KSE-AntiSpam-Info: FromAlignment: s X-KSE-AntiSpam-Info: ApMailHostAddress: 213.87.154.82 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 19 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 09/30/2024 19:29:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 9/30/2024 3:37:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit On 9/30/24 19:08, Paul Barker wrote: > From: Paul Barker > > The GbEth IP will pass through a null UDP checksum without asserting any s/null/zero/, perhaps? > error flags so we do not need to resort to software checksum calculation > in this case. > > Signed-off-by: Paul Barker Reviewed-by: Sergey Shtylyov [...] > diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c > index 9350ca10ab22..ae0268f2eb04 100644 > --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.c > @@ -2075,20 +2075,12 @@ static bool ravb_can_tx_csum_gbeth(struct sk_buff *skb) > > switch (ip->protocol) { > case IPPROTO_TCP: > - break; > case IPPROTO_UDP: > - /* If the checksum value in the UDP header field is 0, TOE does > - * not calculate checksum for UDP part of this frame as it is > - * optional function as per standards. > - */ > - if (udp_hdr(skb)->check == 0) > - return false; > - break; > + return true; > + No need for an empty line here, it's not used elsewhere in the *switch* statements... > default: > return false; > } [...] MBR, Sergey