From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 334262E041D for ; Sat, 7 Feb 2026 18:09:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770487779; cv=none; b=CmvmtXz9U1ElzgIcsiHu+Zv+Uhb2DO4FuorPrKVClLCUoSMJhvUggbJxus1aVX+gwnmmyxL0irJYcSP6VaLhhgZQHZV8kgUJ0EeWCDRJeN6YpYKloLgHYRp+pcpcMzXBiVN3VcqarL4vbzI1uHW0it7dP11mSaCFiM3gW80ZwbA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770487779; c=relaxed/simple; bh=Z1RlCkvjAKV6GMKhbwoWjgZvhZGNQ0TOlPqMxvRH9eY=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=NxjnGiGVo+TZNZUnz1u/9w3055IPnRibGoRzDsWn+hdyojSCvKWW6M2I1ieyqubZf4trD31stvicUZnejHXEJtqwr6Wex3bmPMZ1KTNsoxeBVOMzR8hqW6Tgk1bn8IN0Xnt6Gxjkpesk2UwgPdjjAXlzv67JEOkbBOpRAIid9zY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=YasdDXT+; arc=none smtp.client-ip=209.85.160.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="YasdDXT+" Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-4044854464fso2069277fac.3 for ; Sat, 07 Feb 2026 10:09:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1770487778; x=1771092578; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=doeEscZbmqUzRLkmGbD2wulpXvhEwLpY3gZ7s/QLWDw=; b=YasdDXT+PSQGxVL4yqiV6baqDWcuTn+aeYlC+08D6q3bByU6qswlUJW1KJvBtFfb8G ddtfvmCXJoFMI8tHG61s7X+7EFfJD0mgiXEPxghWHI5g42E2/crplxnXzmXurq/drRAA zek9l3gXbx1r0F8SPaEbUxDTGs/75oBfhJgLq8degjPmTGBWglKMfvPvQ9ZHA2UQsavj yk9Hhw8lwi4K31syJ7STbd1o57+POIfmgrJfgYaSywTWdi4UVmeg7jgR+e1Oi/JkrSa0 /CikZAy0wJzfW6f/2MZ8A6EZvnzrahxEvfj/7YHUIHbATVWzqD0oBLLLwAkUnaUNF4Pb WM/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770487778; x=1771092578; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=doeEscZbmqUzRLkmGbD2wulpXvhEwLpY3gZ7s/QLWDw=; b=ifkPeTcMklC78BtvYrnpDWGxwa8hTzJGnhkbEtORXhJNt+840PoQW6Iq2+ddBYSBxv 0pdnGKG8iT+E4KinoWmoR69+DRISURd11j7KjYlaO85TXPcAgcJSBpcuvkMG+Olo96dJ crDgdFNjvYT0ewMpWnZenlYcAzby5qP6kuCwV2vTdIgJfD+qLmaCL4I5vzOJnsEkLONK fGjLB9xfTayeSWywXiutPHNG/s8qNtgRk6aw9XDrbqnGnlqRE0G2Yk2wStATmHrSIUd4 nBb1SXKgy8Fpqyzj8QfCV4vi/x8Ub68QspfOnC7ib+RHWjm78kXAeO/7I18HtqdXigGM IrXA== X-Forwarded-Encrypted: i=1; AJvYcCUdPBxh+/qa4mL3yfl2LyjNKVW8gbEcj/mLVNt0z2m2vGCu0bc3jVfqtSlRWy0v4DerMa7brZ4hc+r9VG0=@vger.kernel.org X-Gm-Message-State: AOJu0YxyEayU9OV9kahp3cub+yQysnlrP5exaeRpYOQqz0RZr9VgxRre U/EZ/TAlNAMJuqhOB7dcEQsu7RiS2FDyuoM8Kh9XMdnscFdSLCF7J/2XX7UA5qaCddM= X-Gm-Gg: AZuq6aLXJii35xi8ZNVw73PKkB7xetZUXEXERKLr8u5mFXsmLdyRCrSc+oSONxit830 U7linrK+NZGRY/GTWPibrLdst7xccpngj2Vi+dnRyFkfP3fiZaTs6VuobylMOQZ+9rpEoJFG/WP WJDjD81VC8dotXxU9wIBBeiItg4Sx7YYCvXEe1my/VfNtOaQETph9IaZ43EfcWjSGsIu4zPtcPe 73Y69eQcUaP8uYXs2Gk9gCBxSBRNVD/Y8+7alqgn25Ydklv+YvBzMwL8xEwvXmIzgD7mg3BW9Zs XvqabbhZcRQzOIQ5X47cl+56AlyjthPlC5BtISzzMWKMMv/Wg60GwAkwVIwzTJkLdrZyGxHJFkm l3aFY5kXbPDmuSKcl2gp7DzNxeCS4t405Cm/biG5AIgGIvT8wyTtAVI6sCHacjps8dhko5KS/2M zh8UsnFFsfohtrEQRbQQ+mbi98P3kg6KA9c6IJsBoKWM3vNBJ4hq0BEFykQOmjAHMZK2Q2 X-Received: by 2002:a05:6870:799a:b0:3ec:321c:b2ac with SMTP id 586e51a60fabf-40a9777b8c4mr3621662fac.37.1770487778043; Sat, 07 Feb 2026 10:09:38 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:74a6:843b:f33:21ae? ([2600:8803:e7e4:500:74a6:843b:f33:21ae]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-40a99787738sm4509503fac.15.2026.02.07.10.09.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Feb 2026 10:09:36 -0800 (PST) Message-ID: <8fbfcf7c-4acd-4a7f-a5a5-34baad84e1b2@baylibre.com> Date: Sat, 7 Feb 2026 12:09:34 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] spi: allow ancillary devices to share parent's chip selects To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Olivier Moysan , Mark Brown , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org References: Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/6/26 10:07 AM, Antoniu Miclaus wrote: > When registering an ancillary SPI device, the current code flags a chip > select conflict with the parent device. This happens because the > ancillary device intentionally uses one of the parent's chip selects, > but __spi_add_device() checks against all existing devices including > the parent. > > Allow this by passing the parent device pointer to __spi_add_device() > and skipping the conflict check when the existing device is the parent. > ... > static int spi_dev_check(struct device *dev, void *data) > { > struct spi_device *spi = to_spi_device(dev); > - struct spi_device *new_spi = data; > + struct spi_dev_check_info *info = data; > + struct spi_device *new_spi = info->new_spi; > int status, idx; > > + /* > + * When registering an ancillary device, skip checking against the > + * parent device since the ancillary is intentionally using one of > + * the parent's chip selects. > + */ > + if (info->parent && spi == info->parent) spi should never be NULL (or we would get a segfault later), so if `(spi == info->parent)` should be enough. > + return 0; > + Reviewed-by: David Lechner