From: Haiyang Zhang <haiyangz@microsoft.com>
To: David Miller <davem@davemloft.net>,
"thomas1206@gmail.com" <thomas1206@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
KY Srinivasan <kys@microsoft.com>,
"olaf@aepfle.de" <olaf@aepfle.de>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"driverdev-devel@linuxdriverproject.org"
<driverdev-devel@linuxdriverproject.org>
Subject: RE: [PATCH net-next] hyperv: Increase the buffer length for netvsc_channel_cb()
Date: Tue, 5 Aug 2014 20:12:42 +0000 [thread overview]
Message-ID: <8fc1fe81db1b450685921f9ea97f8477@DFM-DB3MBX15-06.exchange.corp.microsoft.com> (raw)
In-Reply-To: <20140805.130346.2080401893280146356.davem@davemloft.net>
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Tuesday, August 5, 2014 4:04 PM
> To: thomas1206@gmail.com
> Cc: netdev@vger.kernel.org; Haiyang Zhang; KY Srinivasan; olaf@aepfle.de;
> jasowang@redhat.com; linux-kernel@vger.kernel.org; driverdev-
> devel@linuxdriverproject.org
> Subject: Re: [PATCH net-next] hyperv: Increase the buffer length for
> netvsc_channel_cb()
>
> From: Haiyang Zhang <thomas1206@gmail.com>
> Date: Fri, 1 Aug 2014 15:55:30 +0000
>
> > When the buffer is too small for a packet from VMBus, a bigger buffer
> will be
> > allocated in netvsc_channel_cb() and retry reading the packet from
> VMBus.
> > Increasing this buffer size will reduce the retry overhead.
> >
> > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> > Reviewed-by: Dexuan Cui <decui@microsoft.com>
>
> I'm not applying this, sorry.
>
> I said that because the structure that contains this buffer is now
> larger than a page, you should allocate the CB buffer externally
> via another kmalloc() or via the page allocator.
This must have been re-sent accidentally when we are updating our
Email server... I will update the patch and re-submit it soon.
Thanks,
- Haiyang
next prev parent reply other threads:[~2014-08-05 20:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 15:55 Haiyang Zhang
2014-08-05 20:03 ` David Miller
2014-08-05 20:12 ` Haiyang Zhang [this message]
2014-08-04 19:33 Haiyang Zhang
2014-08-04 22:08 ` David Miller
2014-08-04 22:34 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fc1fe81db1b450685921f9ea97f8477@DFM-DB3MBX15-06.exchange.corp.microsoft.com \
--to=haiyangz@microsoft.com \
--cc=davem@davemloft.net \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=thomas1206@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®