From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: David Heidelberg <david@ixit.cz>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, - <kernel@puri.sm>
Cc: "Guido Günther" <agx@sigxcpu.org>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: sound: gtm601: convert to YAML
Date: Sun, 30 Jul 2023 21:13:31 +0200 [thread overview]
Message-ID: <8fc36939-49e7-4422-be94-ce57a82a56f6@linaro.org> (raw)
In-Reply-To: <20230730190243.113105-1-david@ixit.cz>
On 30/07/2023 21:02, David Heidelberg wrote:
> Convert GTM601 binding to the YAML format.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> v3:
> - incorporated feedback from Krzysztof
...
> +properties:
> + compatible:
> + oneOf:
> + - items: # 48 kHz stereo
> + - const: broadmobi,bm818
> + - const: option,gtm601
> + - const: option,gtm601 # 8 kHz mono
> +
> + '#sound-dai-cells':
> + const: 0
> +
> +allOf:
> + - $ref: dai-common.yaml#
> +
> +additionalProperties: false
I missed one thing in the previous review, sorry. Something was looking
here as missing but my brain did not work. Please add "required:" with
compatible.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-07-30 19:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-30 19:02 David Heidelberg
2023-07-30 19:13 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fc36939-49e7-4422-be94-ce57a82a56f6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agx@sigxcpu.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=kernel@puri.sm \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®