From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Bjorn Andersson <andersson@kernel.org>,
Joseph Chen <chenjh@rock-chips.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH 8/8] regulator: fan53555: Add support for RK860X
Date: Thu, 6 Apr 2023 14:15:34 +0300 [thread overview]
Message-ID: <8fc46929-6d73-ea75-f44f-b83820c0e5df@collabora.com> (raw)
In-Reply-To: <231b72cd-352c-10a9-8695-a04f61e36568@linaro.org>
On 4/6/23 14:03, Krzysztof Kozlowski wrote:
> On 06/04/2023 12:08, Cristian Ciocaltea wrote:
>>>> + }, {
>>>> + .name = "rk8602",
>>>> + .driver_data = RK8602_VENDOR_ROCKCHIP
>>>> + }, {
>>>> + .name = "rk8603",
>>>> + .driver_data = RK8602_VENDOR_ROCKCHIP
>>>
>>> Why do you need this entry match data if it is the same as rk8602?
>>
>> This is consistent with the handling of syr827 and syr828:
>>
>> .name = "syr827",
>> .driver_data = FAN53555_VENDOR_SILERGY
>> }, {
>> .name = "syr828",
>> .driver_data = FAN53555_VENDOR_SILERGY
>
> Yeah, I understand, but it's not necessarily the pattern we want to
> continue. Unless these devices are not really compatible?
They are compatible, so should I simply drop the rk8601 and rk8603 entries?
Probably also renaming rk8600 and rk8602, though I'm not sure what a
proper naming scheme would be to combine the 2 variants for each.
Thanks,
Cristian
next prev parent reply other threads:[~2023-04-06 11:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 19:47 [PATCH 0/8] Add support for Rockchip RK860X regulators Cristian Ciocaltea
2023-04-05 19:47 ` [PATCH 1/8] regulator: dt-bindings: fcs,fan53555: Add support for RK860X Cristian Ciocaltea
2023-04-06 8:24 ` Krzysztof Kozlowski
2023-04-05 19:47 ` [PATCH 2/8] regulator: fan53555: Explicitly include bits header Cristian Ciocaltea
2023-04-05 19:47 ` [PATCH 3/8] regulator: fan53555: Fix wrong TCS_SLEW_MASK Cristian Ciocaltea
2023-04-05 19:47 ` [PATCH 4/8] regulator: fan53555: Remove unused *_SLEW_SHIFT definitions Cristian Ciocaltea
2023-04-05 19:47 ` [PATCH 5/8] regulator: fan53555: Make use of the bit macros Cristian Ciocaltea
2023-04-05 19:47 ` [PATCH 6/8] regulator: fan53555: Improve vsel_mask computation Cristian Ciocaltea
2023-04-05 19:47 ` [PATCH 7/8] regulator: fan53555: Use dev_err_probe Cristian Ciocaltea
2023-04-05 19:47 ` [PATCH 8/8] regulator: fan53555: Add support for RK860X Cristian Ciocaltea
2023-04-06 8:25 ` Krzysztof Kozlowski
2023-04-06 10:08 ` Cristian Ciocaltea
2023-04-06 11:03 ` Krzysztof Kozlowski
2023-04-06 11:15 ` Cristian Ciocaltea [this message]
2023-04-06 17:40 ` Cristian Ciocaltea
2023-04-06 18:13 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fc46929-6d73-ea75-f44f-b83820c0e5df@collabora.com \
--to=cristian.ciocaltea@collabora.com \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=chenjh@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®