From: "Simmons, James A." <simmonsja@ornl.gov>
To: "'Dilger, Andreas'" <andreas.dilger@intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
James Simmons <jsimmons@infradead.org>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Drokin, Oleg" <oleg.drokin@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"lustre-devel@lists.lustre.org" <lustre-devel@lists.lustre.org>
Subject: RE: [lustre-devel] [PATCH v3 5/8] staging:lustre: separate kernel and user land defines in the LNet headers
Date: Tue, 9 Jun 2015 14:59:26 +0000 [thread overview]
Message-ID: <8fc5cd45fda6439f9cad8c8a7b504db9@EXCHCS32.ornl.gov> (raw)
In-Reply-To: <D19B6F47.F5921%andreas.dilger@intel.com>
>On 2015/06/05, 3:02 AM, "Dan Carpenter" <dan.carpenter@oracle.com> wrote:
>
>>On Wed, Jun 03, 2015 at 04:43:24PM -0400, James Simmons wrote:
>>> Currently the lnet headers used by user land contain various internal
>>> LNet structures that are only used by kernel space. Move the user land
>>> structures to headers used by user land. The kernel structures are
>>> relocated to headers that are never exposed to user land.
>>>
>>> Signed-off-by: James Simmons <jsimmons@infradead.org>
>>> ---
>>> diff --git a/drivers/staging/lustre/lnet/lnet/acceptor.c
>>>b/drivers/staging/lustre/lnet/lnet/acceptor.c
>>> index 1dc7c8a..4928f5c 100644
>>> --- a/drivers/staging/lustre/lnet/lnet/acceptor.c
>>> +++ b/drivers/staging/lustre/lnet/lnet/acceptor.c
>>> @@ -243,8 +243,6 @@ lnet_accept(struct socket *sock, __u32 magic)
>>>
>>> if (magic == le32_to_cpu(LNET_PROTO_TCP_MAGIC))
>>> str = "'old' socknal/tcpnal";
>>> - else if (lnet_accept_magic(magic, LNET_PROTO_RA_MAGIC))
>>> - str = "'old' ranal";
>>> else
>>> str = "unrecognised";
>>>
>>
>>Presumably this was done intentionally. We deleted LNET_PROTO_RA_MAGIC.
>>The changelog was not very clear why.
>
>The "Rapid Array" network interface is an obsolete network once used by
>Cray hardware but hasn't been supported for about 10 years and was (mostly)
>deleted from the tree already. This was just a left-over I guess.
I need to break this patch up and do a proper backport of the patch from LU-6209.
Currently it is mixed in with this header cleanup.
next prev parent reply other threads:[~2015-06-09 14:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 20:43 [PATCH v3 0/8] staging:lustre: remove kernel defines in userland headers James Simmons
2015-06-03 20:43 ` [PATCH v3 1/8] staging:lustre: assume a kernel build James Simmons
2015-06-05 9:02 ` Dan Carpenter
2015-06-03 20:43 ` [PATCH v3 2/8] staging:lustre: fixup LNet resource container api James Simmons
2015-06-03 20:43 ` [PATCH v3 3/8] staging:lustre: delete no longer used LNet headers James Simmons
2015-06-08 19:38 ` Greg Kroah-Hartman
2015-06-03 20:43 ` [PATCH v3 4/8] staging:lustre: move LNet NID macros to LNet layer James Simmons
2015-06-03 20:43 ` [PATCH v3 5/8] staging:lustre: separate kernel and user land defines in the LNet headers James Simmons
2015-06-05 9:02 ` Dan Carpenter
2015-06-09 0:33 ` [lustre-devel] " Dilger, Andreas
2015-06-09 14:59 ` Simmons, James A. [this message]
2015-06-03 20:43 ` [PATCH v3 6/8] staging:lustre: fix camel case for LNetInit and LNetFini James Simmons
2015-06-03 20:43 ` [PATCH v3 7/8] staging:lustre: style cleanups for LNet headers James Simmons
2015-06-05 9:04 ` Dan Carpenter
2015-06-09 15:01 ` [lustre-devel] " Simmons, James A.
2015-06-03 20:43 ` [PATCH v3 8/8] staging:lustre: Update license and copyright for the LNET headers James Simmons
2015-06-04 6:19 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fc5cd45fda6439f9cad8c8a7b504db9@EXCHCS32.ornl.gov \
--to=simmonsja@ornl.gov \
--cc=andreas.dilger@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®