From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AEA83F99F4 for ; Fri, 11 Sep 2026 07:36:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789112189; cv=none; b=CFVctKjn0fLqE/PvdZBZVzb6ESTCXMdP8OBko63FQqkwBWXw8oH0v6R8qmonyeE/3Hp0ZVDp3hIZ9qt0PTNtdjw4ysEnV5J0uRPdi7tSX2OOukEkJBMhbGKAwEUoQIpPR4fOnfPqopbxEi6qg35yXLk30uhtLChQ6qCm7tO+EdE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789112189; c=relaxed/simple; bh=fsWO5RfUtrwYBghqZbddt7joHj5CDeK4xYY0+hFA124=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=InvuBf0s7cHCz2t0mSaNh7Nm5i3d8dH2hI6TUVK6Pi52qB6e4G2ZLYM8jvrYUC6hydNsDdcWJgizsZ5lhN0Uxy4g/zE9U+aq1qMIPLnOVyahnGsPrmJ3jIA0I3aoD8ml+1r/cw/DldEn66jLWn2qR23KPlRzB9XwtmwyT1CWUrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=Qkaji6DE; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Qkaji6DE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1789112186; bh=fsWO5RfUtrwYBghqZbddt7joHj5CDeK4xYY0+hFA124=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Qkaji6DEBChYB6Y1WQhTLVJgKyo3Ywqi8KCx2nY3VQm2QuhK6l0yLy/DVuZeBbHf7 Qkg9/u23+zPY1aMuhsNdEnkZ/84v/EInCLzKV/hnd9Ga1Og8FQ9WLKpR86/Dbghy1v OKo+pptyBeZ7pFKyQYQydwrnBZlKxoM8U6Kk1wx33TeXEIo9K8XLNIIWyGgOn951Q5 HB1s6+cEDdbFopVBRAxAEeJo61OYb3IUwWtM+gqVapJkHRCFfx6h+M3UwP4B9o965U AwOaXyKI/9gJOD0VBpfQiGL0H8BLP1L5VGAXqJ4k2K44w5jxUunabAzBmcaJieRDLE iBfpIEDY2850w== Received: from [100.64.1.21] (unknown [100.64.1.21]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 77FA917E0260; Fri, 11 Sep 2026 09:36:25 +0200 (CEST) Message-ID: <8fc8791a-911b-4c17-b291-5bdd468335ce@collabora.com> Date: Fri, 11 Sep 2026 09:36:24 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] phy: mediatek: phy-mtk-hdmi-mt8195: Fix TMDS clk bit ratio setting To: Manivannan Sadhasivam Cc: chunfeng.yun@mediatek.com, p.zabel@pengutronix.de, chunkuang.hu@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, matthias.bgg@gmail.com, granquet@baylibre.com, justin.yeh@mediatek.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20260701121936.19407-1-angelogioacchino.delregno@collabora.com> <20260701121936.19407-3-angelogioacchino.delregno@collabora.com> <5bmxa4pcwkiemubwfjun3dti4szu66gnxe6yw2pudq3wplpc23@inyswc2bdlhw> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/11/26 07:11, Manivannan Sadhasivam wrote: > On Thu, Sep 10, 2026 at 10:39:06AM +0200, AngeloGioacchino Del Regno wrote: >> On 9/9/26 17:06, Manivannan Sadhasivam wrote: >>> On Wed, Jul 01, 2026 at 02:19:36PM +0200, AngeloGioacchino Del Regno wrote: >>>> The comment in the mtk_phy_tmds_clk_ratio() function clearly and >>>> correctly explains that the TMDS ratio has to be 1/10 for data >>>> rates under 3.4Gbps, and 1/40 over that. >>>> >>>> Unfortunately though, the TXC_DIV register setting was wrong, as >>>> in value 3 means to divide by 8 and, in order to achieve the in >>>> spec 1/40 (tmds) data rate, this has to divide by 4 instead! >>>> In order to achieve the correct 1/40 (tmds) data rate, this has >>> >>> This statement is cut-off! >>> >> >> Oh oops. It's just a forgotten line that has to be removed.... >> >> Should I resend or can you simply remove the line >> "In order to achieve the correct 1/40 (tmds) data rate, this has" >> while applying? >> > > I do not apply the patches, only Vinod does. It would help if you can just > send a next version with this change and tags. > > - Mani > Sure, will send v2 in a jiffy. Cheers, Angelo