From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752002AbeERQd3 (ORCPT ); Fri, 18 May 2018 12:33:29 -0400 Received: from mail-pl0-f67.google.com ([209.85.160.67]:39550 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbeERQd0 (ORCPT ); Fri, 18 May 2018 12:33:26 -0400 X-Google-Smtp-Source: AB8JxZrTlRggoJFbxMfav63QxqQz+Rrhj2mjmUdnQdg/oStVy17eVWc3KY7yzwR+b4JpUBWryvK9dA== Subject: Re: [PATCH 00/10] Misc block layer patches for bcachefs To: Christoph Hellwig Cc: Kent Overstreet , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, Ingo Molnar References: <20180509013358.16399-1-kent.overstreet@gmail.com> <20180518162314.GC25227@infradead.org> From: Jens Axboe Message-ID: <8fcb7b62-d3ac-54b6-3cb7-45864cafe2b1@kernel.dk> Date: Fri, 18 May 2018 10:33:22 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180518162314.GC25227@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/18/18 10:23 AM, Christoph Hellwig wrote: > On Fri, May 11, 2018 at 03:13:38PM -0600, Jens Axboe wrote: >> Looked over the series, and looks like both good cleanups and optimizations. >> If we can get the mempool patch sorted, I can apply this for 4.18. > > FYI, I agree on the actual cleanups and optimization, but we really > shouldn't add new functions or even just exports without the code > using them. I think it is enough if we can collect ACKs on them, but > there is no point in using them. Especially as I'd really like to see > the users for some of them first. I certainly agree on that in general, but at the same time it makes the expected submission of bcachefs not having to carry a number of (essentially) unrelated patches. I'm assuming the likelihood of bcachefs being submitted soonish is high, hence we won't have exports that don't have in-kernel users in the longer term. -- Jens Axboe