From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750896AbdANNKr (ORCPT ); Sat, 14 Jan 2017 08:10:47 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:51418 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750713AbdANNKq (ORCPT ); Sat, 14 Jan 2017 08:10:46 -0500 Subject: Re: [PATCH] iio: magnetometer: ak8974: remove redundant zero timeout check To: Linus Walleij , Colin King References: <20170111174933.22523-1-colin.king@canonical.com> Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Jonathan Cameron Message-ID: <8fccb220-4254-bc36-e1bc-abfb54a4fda6@kernel.org> Date: Sat, 14 Jan 2017 13:10:43 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/01/17 23:11, Linus Walleij wrote: > On Wed, Jan 11, 2017 at 6:49 PM, Colin King wrote: > >> From: Colin Ian King >> >> At the end of the delay loop timeout will always be zero >> and hence the check for !timeout will always be true. Remove >> the redundant check and the redundant return 0 at the end of >> the function. >> >> Fixes CoverityScan CID#1357168 ("Logically dead code") >> >> Signed-off-by: Colin Ian King > > Clever Coverity scan. > Reviewed-by: Linus Walleij > Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > Yours, > Linus Walleij > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >