From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A564B41226E for ; Tue, 7 Jul 2026 12:44:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783428243; cv=none; b=JdCZUeX8FNKGLfCgDH+jL/zDfYq2zZjQVDENAEZMsESJ82a0mZ7+ob00lt+Q/6Xw6zjcmtjCrbB+kzH+D3o9nJwPVb6vUKRzLJegrSFYJEjvfs2xyBVwlbKg+95K8CtJChzVjEx7TEh4M8JOnAEHkHTHs2t1xQL9ZmTzEcU7IRU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783428243; c=relaxed/simple; bh=jj2vRusPH5dQvYdLb63Wzcj6U93bufwVr67iZ8YvRfQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L7UA5CwxQXWEgn20D23DvUcqCGKGAAxeWW7p4G628dJPzenHdD5nl8EcbyGJhMwz+AXlNnULQ+AVXbjMPA2YdvVjA55HIpi3B8PPp48Cwf9kqpNe7M/zS5VMPhH3lUOmZcydgs0MQ17Yyb7OYXj+cvrQvZcckDkwZS/6qXDUa+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XD7NvtCv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bzEYPvD7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XD7NvtCv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bzEYPvD7" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 667C93qU3590163 for ; Tue, 7 Jul 2026 12:44:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jsF8+lnCV59+0yqeWXdSHV6D3xLFbynXeMN7huNriQ0=; b=XD7NvtCvt+ciicLc SFxlsBX3lxxlCeJzhe7+FCQ7sllI9nmp83Wp7Q5Sdw/jmrb5rQBlLklY94ke8uxl K6pKpodACkGCwZANRoY/ahbVze0XEd0WNFcHhLwgU45NyWXU71Lmy0HjRcqBT1/2 3Us/ZWIr7YBgPOnRx+bZ6X4v/YQLBykVEJDkInXoliJRFKkAS5aeKDAGa9+eRVFX Pmfneoxro2uCyK3yJpFMhoyo8ImDUV4ajCP+8UxV1LpodyHlMaOY+ojAQ8Y6Gkz+ jxvu/VCOpPonyiTABDAOLAeapPcB7X82j1ji7/KjywSz0hc9DpPkkJ65jwHRwfOp nEXIpg== Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8w2u97e1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Jul 2026 12:44:00 +0000 (GMT) Received: by mail-oo1-f71.google.com with SMTP id 006d021491bc7-6a0f261aeb6so5644922eaf.3 for ; Tue, 07 Jul 2026 05:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783428240; x=1784033040; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jsF8+lnCV59+0yqeWXdSHV6D3xLFbynXeMN7huNriQ0=; b=bzEYPvD7MuTxh96I2NHVrmTLlSi2chC9UtilwlZMgKRan14wedDfbA8zCV2PZFoEmi qNF2KLBzxs8xuaXPNSIbLSRgvlB3OKqXrXhg6VThYc6Mz62NE8Dn8Ln6hbpHGH7mWcDF FwhdrnBpyuUxbCCcYxFqoxfqwmRK3xxPkExYLAFNNjF7Y7VypN+GA/Fn6dst1oPMHPHQ LrB/YvLeL9d66pODoXKxC4osLdy4ZEc166Itj2OCOJc2y2wahFygY9w71rYtj7eF5gAd dIT1cj0fkM1dKk/zC5vVQ8jhCuMCgbOvoST9/K8h7iu9MEsqzC/nORLzkd7qn6v/q+xI sQKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783428240; x=1784033040; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jsF8+lnCV59+0yqeWXdSHV6D3xLFbynXeMN7huNriQ0=; b=gZU82s9YnaC+TP4Yz0+ALo351k71QyDnl1s27qgKrQzmMYa1TFfPYOyHzdDv8UZse/ hPqv04yxYPdLccWGnq/QGt6HgTEIrjr2IpvP80lf82DrdDpyv+0wapvxV4wXGM9+N0OI sKiVM2WCqeZL6R4emZlIWNt2hky6WbzCTKQzu2XXMG4FgQKaiJmL9WF+EBsLeWvFbY7+ OIJAfFTYaLE6tbEiysKILeZc1eO+53T1SY8FHUyw4exD19dlnHf8qGZCrkVZXfpPf6dt 9IhcXRu4yP3bmCkowv2xhROH6AHPp1j82MiYRKc4zWUepGtXkge0jgKnzZ5UqxDbFd7O mUvQ== X-Forwarded-Encrypted: i=1; AFNElJ86bbrHYumiIDO+rrtPBfTEell9P+wExasW4hJ4CpXgRaT+ZUh4ECFGX8ipJCcaBb/jyEuZvz3pE5uu+OI=@vger.kernel.org X-Gm-Message-State: AOJu0Yxt4TnLpSkB9oA+J5RsyX/Ve2F1KIlIMONAIzGCkQQaiSe+Dj4P 5SrBq2aj/SzDK+XMA04GgU/z/y0lwFfSf8ydi/kFUp0c58Ou2M0j0O4e4VhzLUscv9r4KBsIh+D VQ4IddGujCGmFbpOh7DY+KKP9Bxnz3UxotTiPAEyXDcadJgHTzQXEadGHRJXgH1X8bUY= X-Gm-Gg: AfdE7ckZoPYT4OzGkGtL6UOJ7n5mE32WLh03HxCqyrDi7WiNfzJLHaByO9/t4w250AF bCHMMeH5ym6fhLJGYZO1gjcDxKUpFv7N+lwAYKR0ukMFPNu0MULTu84JNmZO5DQdDMGba2fvvGw 3BOm4vylNh50eYJRVWBqHiaX3XM76Uq/ww5spLh2uNlBwqATbNgRsgb4+gl49+2eHc9qtoGm+Zu GnbwynVFtlus3jzhl/4VCjDya17U0Zmf83XiKhBfTtlGsXxpu7c9+ownhxw3UkMW+fTxr7off4r U3kL44oFHI3/tAL9MaMamf+KKhxduXRROm8Nbjt1Josq59xZcF6uIMzWOURDNfu0/LNiiJNjv0E DzG0UdqlATn7FR8ekykNkuT1qRqdpojtcFmDHsW4= X-Received: by 2002:a05:6820:f004:b0:6a0:f3b5:12a2 with SMTP id 006d021491bc7-6a3553978e6mr3648871eaf.20.1783428237522; Tue, 07 Jul 2026 05:43:57 -0700 (PDT) X-Received: by 2002:a05:6820:f004:b0:6a0:f3b5:12a2 with SMTP id 006d021491bc7-6a3553978e6mr3648859eaf.20.1783428237043; Tue, 07 Jul 2026 05:43:57 -0700 (PDT) Received: from [10.219.56.198] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6a31fd2cf7asm8442320eaf.4.2026.07.07.05.43.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2026 05:43:56 -0700 (PDT) Message-ID: <8fcdb7be-0bb4-4cf5-b969-6e5b0b516f87@oss.qualcomm.com> Date: Tue, 7 Jul 2026 18:13:50 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/6] iommu/arm-smmu: Add interconnect bandwidth voting support To: Dmitry Baryshkov Cc: Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Rob Clark , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260706-smmu_interconnect_addition-v3-0-afdca0125a65@oss.qualcomm.com> <20260706-smmu_interconnect_addition-v3-2-afdca0125a65@oss.qualcomm.com> Content-Language: en-US From: Bibek Kumar Patro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA3MDEyMyBTYWx0ZWRfXz7xgcEqPRhgR Be0dq+cnRHWFBXXqewbadthk3f6xpV6m1nyZWVe3u6AAjsD5GOD+XLU9ugivN632wnNjmlpD7hh Neun2VRyGW9qqiRP5TD/P/CWpTvkwZE= X-Proofpoint-GUID: eNfr4Qz2Rqevh-pXXvX7jhWwrQW2saCN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA3MDEyMyBTYWx0ZWRfXzDb6THgO4nf1 OoPJBfMQT+KcylUePfSStfoHlCwULyZVn50MDPhOStGupC4UzcYcp5RWANPd0ekR+uVrVYrQ9oW Mlp01fLMSLBOt12CTVSAaFT8xn5XdfXqgtx3qAyWFschiN8Eqj2NmtV7JhOIqlgV+jdtpNXqGNC me7Zc40x/16vVZ1f4t6xsf5e4hjHSXy2YCoBdSE2v1h7LsLxyC6pXxemrLm0m/O/ND0bxzzpV80 Qgatt6jHg9KmBtHOo08gFcZnitY0YRPp8cFAqIAgh0ddsoE0qgD43CsdtLi5p28fPlk2AFxW+aJ DER1YtWqTJy+qYK22sRVRJ+2VS9ehZWrMlRP9s3sp4sdPlgDZwb2D9JBRQ8Qc+GiFszAAU/DzLA 6QqDr75+E2XGg/JuTlcIg+FLXJIgSVo6WyCjHYdo4MhU4shUqFR/FMRfDKNveQxB6Oqf69J2PDz k5szCIXeLQyIqDctoLw== X-Proofpoint-ORIG-GUID: eNfr4Qz2Rqevh-pXXvX7jhWwrQW2saCN X-Authority-Analysis: v=2.4 cv=bPQm5v+Z c=1 sm=1 tr=0 ts=6a4cf490 cx=c_pps a=V4L7fE8DliODT/OoDI2WOg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=RRvI01qy6g1rNRViaBEA:9 a=QEXdDO2ut3YA:10 a=WZGXeFmKUf7gPmL3hEjn:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_03,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607070123 On 7/6/2026 11:10 PM, Dmitry Baryshkov wrote: > On Mon, Jul 06, 2026 at 10:26:35PM +0530, Bibek Kumar Patro wrote: >> On some SoCs the SMMU registers require an active interconnect >> bandwidth vote to be accessible. While other clients typically >> satisfy this requirement implicitly, certain corner cases (e.g. >> during sleep/wakeup transitions) can leave the SMMU without a >> vote, causing intermittent register access failures. >> >> Add support for an optional interconnect path to the arm-smmu >> driver and vote for bandwidth while the SMMU is active. The path >> is acquired from DT if present and ignored otherwise. >> >> The bandwidth vote is enabled before accessing SMMU registers >> during probe and runtime resume, and released during runtime >> suspend and on error paths. >> >> Generally, from an architectural perspective, GEM_NOC and DDR are >> expected to have an active vote whenever the adreno_smmu block is >> powered on. In most common use cases, this requirement is implicitly >> satisfied because other GPU-related clients (for example, the GMU >> device) already hold a GEM_NOC vote when adreno_smmu is enabled. >> >> However, there are certain corner cases, such as during sleep/wakeup >> transitions, where the GEM_NOC vote can be removed before adreno_smmu >> is powered down. If adreno_smmu is then accessed while the interconnect >> vote is missing, it can lead to the observed failures. Because of the >> precise ordering involved, this scenario is difficult to reproduce >> consistently. >> (also GDSC is involved in adreno usecases can have an independent vote) >> >> Signed-off-by: Bibek Kumar Patro >> --- >> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 55 +++++++++++++++++++++++++++++- >> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.h | 3 ++ >> drivers/iommu/arm/arm-smmu/arm-smmu.c | 27 +++++++++++++-- >> drivers/iommu/arm/arm-smmu/arm-smmu.h | 2 ++ >> 4 files changed, 84 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c >> index e2c914fccd6f..5133d3ab023a 100644 >> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c >> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c >> @@ -6,6 +6,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -607,6 +608,45 @@ static int qcom_sdm845_smmu500_reset(struct arm_smmu_device *smmu) >> return ret; >> } >> >> +static int qcom_adreno_smmu_icc_init(struct arm_smmu_device *smmu) >> +{ >> + struct qcom_smmu *qsmmu = container_of(smmu, struct qcom_smmu, smmu); >> + int err; >> + >> + qsmmu->icc_path = devm_of_icc_get(smmu->dev, NULL); >> + if (!IS_ERR(qsmmu->icc_path)) >> + return 0; >> + >> + err = PTR_ERR(qsmmu->icc_path); >> + >> + if (err == -ENODEV) { >> + qsmmu->icc_path = NULL; >> + return 0; >> + } >> + return dev_err_probe(smmu->dev, err, >> + "failed to get interconnect path\n"); >> +} >> + >> +static int qcom_adreno_smmu_runtime_resume(struct arm_smmu_device *smmu) >> +{ >> + struct qcom_smmu *qsmmu = container_of(smmu, struct qcom_smmu, smmu); >> + int ret; >> + >> + ret = icc_set_bw(qsmmu->icc_path, 0, 1); >> + WARN_ON_ONCE(ret); >> + return ret; >> +} >> + >> +static int qcom_adreno_smmu_runtime_suspend(struct arm_smmu_device *smmu) >> +{ >> + struct qcom_smmu *qsmmu = container_of(smmu, struct qcom_smmu, smmu); >> + int ret; >> + >> + ret = icc_set_bw(qsmmu->icc_path, 0, 0); >> + WARN_ON_ONCE(ret); >> + return ret; >> +} >> + >> static const struct arm_smmu_impl qcom_smmu_v2_impl = { >> .init_context = qcom_smmu_init_context, >> .cfg_probe = qcom_smmu_cfg_probe, >> @@ -648,6 +688,8 @@ static const struct arm_smmu_impl qcom_adreno_smmu_v2_impl = { >> .alloc_context_bank = qcom_adreno_smmu_alloc_context_bank, >> .write_sctlr = qcom_adreno_smmu_write_sctlr, >> .tlb_sync = qcom_smmu_tlb_sync, >> + .runtime_resume = qcom_adreno_smmu_runtime_resume, >> + .runtime_suspend = qcom_adreno_smmu_runtime_suspend, >> .context_fault_needs_threaded_irq = true, >> }; >> >> @@ -658,6 +700,8 @@ static const struct arm_smmu_impl qcom_adreno_smmu_500_impl = { >> .alloc_context_bank = qcom_adreno_smmu_alloc_context_bank, >> .write_sctlr = qcom_adreno_smmu_write_sctlr, >> .tlb_sync = qcom_smmu_tlb_sync, >> + .runtime_resume = qcom_adreno_smmu_runtime_resume, >> + .runtime_suspend = qcom_adreno_smmu_runtime_suspend, >> .context_fault_needs_threaded_irq = true, >> }; >> >> @@ -667,11 +711,14 @@ static struct arm_smmu_device *qcom_smmu_create(struct arm_smmu_device *smmu, >> const struct device_node *np = smmu->dev->of_node; >> const struct arm_smmu_impl *impl; >> struct qcom_smmu *qsmmu; >> + bool is_adreno_smmu; >> + int ret; >> >> if (!data) >> return ERR_PTR(-EINVAL); >> >> - if (np && of_device_is_compatible(np, "qcom,adreno-smmu")) >> + is_adreno_smmu = np && of_device_is_compatible(np, "qcom,adreno-smmu"); >> + if (is_adreno_smmu) >> impl = data->adreno_impl; >> else >> impl = data->impl; >> @@ -691,6 +738,12 @@ static struct arm_smmu_device *qcom_smmu_create(struct arm_smmu_device *smmu, >> qsmmu->smmu.impl = impl; >> qsmmu->data = data; >> >> + if (is_adreno_smmu) { >> + ret = qcom_adreno_smmu_icc_init(&qsmmu->smmu); >> + if (ret) >> + return ERR_PTR(ret); >> + } > > Move this to a runtime hook to be declared in *data. > Ack, will implement this in next revision. >> + >> return &qsmmu->smmu; >> } >> >> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.h b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.h >> index 8addd453f5f1..6835b40339ce 100644 >> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.h >> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.h >> @@ -6,12 +6,15 @@ >> #ifndef _ARM_SMMU_QCOM_H >> #define _ARM_SMMU_QCOM_H >> >> +#include > > Not necessary here. Just forward-declare the struct. > Ack, will take care of this in next revision. Thanks & regards, Bibek >> + >> struct qcom_smmu { >> struct arm_smmu_device smmu; >> const struct qcom_smmu_match_data *data; >> bool bypass_quirk; >> u8 bypass_cbndx; >> u32 stall_enabled; >> + struct icc_path *icc_path; >> }; >> >> enum qcom_smmu_impl_reg_offset { >> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c >> index 0bd21d206eb3..a27804e15738 100644 >> --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c >> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c >> @@ -2189,6 +2189,14 @@ static int arm_smmu_device_probe(struct platform_device *pdev) >> if (err) >> return err; >> >> + if (smmu->impl && smmu->impl->runtime_resume) { >> + err = smmu->impl->runtime_resume(smmu); >> + if (err) { >> + clk_bulk_disable_unprepare(smmu->num_clks, smmu->clks); >> + return err; >> + } >> + } >> + >> err = arm_smmu_device_cfg_probe(smmu); >> if (err) >> return err; >> @@ -2273,8 +2281,11 @@ static void arm_smmu_device_shutdown(struct platform_device *pdev) >> >> if (pm_runtime_enabled(smmu->dev)) >> pm_runtime_force_suspend(smmu->dev); >> - else >> + else { >> clk_bulk_disable(smmu->num_clks, smmu->clks); >> + if (smmu->impl && smmu->impl->runtime_suspend) >> + smmu->impl->runtime_suspend(smmu); >> + } >> >> clk_bulk_unprepare(smmu->num_clks, smmu->clks); >> } >> @@ -2294,9 +2305,18 @@ static int __maybe_unused arm_smmu_runtime_resume(struct device *dev) >> struct arm_smmu_device *smmu = dev_get_drvdata(dev); >> int ret; >> >> + if (smmu->impl && smmu->impl->runtime_resume) { >> + ret = smmu->impl->runtime_resume(smmu); >> + if (ret) >> + return ret; >> + } >> + >> ret = clk_bulk_enable(smmu->num_clks, smmu->clks); >> - if (ret) >> + if (ret) { >> + if (smmu->impl && smmu->impl->runtime_suspend) >> + smmu->impl->runtime_suspend(smmu); >> return ret; >> + } >> >> arm_smmu_device_reset(smmu); >> >> @@ -2309,6 +2329,9 @@ static int __maybe_unused arm_smmu_runtime_suspend(struct device *dev) >> >> clk_bulk_disable(smmu->num_clks, smmu->clks); >> >> + if (smmu->impl && smmu->impl->runtime_suspend) >> + return smmu->impl->runtime_suspend(smmu); >> + >> return 0; >> } >> >> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.h b/drivers/iommu/arm/arm-smmu/arm-smmu.h >> index 26d2e33cd328..ed08f86cf99d 100644 >> --- a/drivers/iommu/arm/arm-smmu/arm-smmu.h >> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.h >> @@ -455,6 +455,8 @@ struct arm_smmu_impl { >> void (*write_s2cr)(struct arm_smmu_device *smmu, int idx); >> void (*write_sctlr)(struct arm_smmu_device *smmu, int idx, u32 reg); >> void (*probe_finalize)(struct arm_smmu_device *smmu, struct device *dev); >> + int (*runtime_resume)(struct arm_smmu_device *smmu); >> + int (*runtime_suspend)(struct arm_smmu_device *smmu); >> }; >> >> #define INVALID_SMENDX -1 >> >> -- >> 2.34.1 >> >