From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5F7FC54FB9 for ; Tue, 21 Nov 2023 10:59:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233096AbjKUK7Z (ORCPT ); Tue, 21 Nov 2023 05:59:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjKUK7X (ORCPT ); Tue, 21 Nov 2023 05:59:23 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B33CD83 for ; Tue, 21 Nov 2023 02:59:19 -0800 (PST) Received: from [100.107.97.3] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 61B9466072F6; Tue, 21 Nov 2023 10:59:17 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1700564358; bh=hLDTvtjHXdN1UWZwGnLWI4X4zJiWHH+M2Ta83yfqwfo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gAvj6e7dR5Diin4goCICBXZjFF0Mbi7wDy70vPr2MNWXzA9tHviIkY3PWf86K/pvy Q8WDKjMTWUL5RqPnWYw07zhdKrpVX8GioYG3k5iIYOX3CFRji0z2lDf8BnuxMrod2H LM908JjgUDU4b0bAT+bhXKkuEeWodKrXiRKvt3IvN06Ye6B3AL7mfoU7q40/wIRqVE asPetWPduA2+TQQ3nZ5N87ylwqDjQOosNtsDQ9YSiVw/MNqEUtYMIsm2DkiFCgwCeF tud5BpwDx8qo2EuUduEn7ApiU8e/RaV6WQqB1tFdZV4ZNySVIF/3hmmBd3GE9fbRx7 Ml/4gYS9CYO4g== Message-ID: <8fd1affd-936d-415e-9f1f-b0415b68ddb6@collabora.com> Date: Tue, 21 Nov 2023 11:59:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/mediatek: dp: Add phy_mtk_dp module as pre-dependency Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Chun-Kuang Hu Cc: kernel@collabora.com, Bo-Chen Chen , CK Hu , Daniel Vetter , David Airlie , Dmitry Osipenko , Guillaume Ranquet , Markus Schneider-Pargmann , Matthias Brugger , Philipp Zabel , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20231120202837.396760-1-nfraprado@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: <20231120202837.396760-1-nfraprado@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 20/11/23 21:28, Nícolas F. R. A. Prado ha scritto: > The mtk_dp driver registers a phy device which is handled by the > phy_mtk_dp driver and assumes that the phy probe will complete > synchronously, proceeding to make use of functionality exposed by that > driver right away. This assumption however is false when the phy driver > is built as a module, causing the mtk_dp driver to fail probe in this > case. > > Add the phy_mtk_dp module as a pre-dependency to the mtk_dp module to > ensure the phy module has been loaded before the dp, so that the phy > probe happens synchrounously and the mtk_dp driver can probe > successfully even with the phy driver built as a module. > You forgot a Suggested-by here :-P > Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") > Signed-off-by: Nícolas F. R. A. Prado It's fine anyway; being the best solution that we can use: Reviewed-by: AngeloGioacchino Del Regno > > --- > > drivers/gpu/drm/mediatek/mtk_dp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c > index e4c16ba9902d..2136a596efa1 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dp.c > +++ b/drivers/gpu/drm/mediatek/mtk_dp.c > @@ -2818,3 +2818,4 @@ MODULE_AUTHOR("Markus Schneider-Pargmann "); > MODULE_AUTHOR("Bo-Chen Chen "); > MODULE_DESCRIPTION("MediaTek DisplayPort Driver"); > MODULE_LICENSE("GPL"); > +MODULE_SOFTDEP("pre: phy_mtk_dp");