From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gz.d.sender-sib.com (gz.d.sender-sib.com [77.32.148.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6304C311C15 for ; Thu, 16 Jul 2026 06:56:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=77.32.148.26 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784185014; cv=none; b=Myth5pes2YfIEdJ8ItwEJiX0EfAGtFCj+jlTHT3A1G2rhzeUjyZ6dGb7O98VnCIkT0M3az2X3uiN7C41h1hmSxvF/o4rNs9Zh4+qtRCxdzCZ+rkAl4hiEdGjkbE78hU/Oa2Vnt7Pk4nJo4I+Sr7J8bjiTKL/OZfdIAh02mxWcGY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784185014; c=relaxed/simple; bh=1LMjw8mVlXizKoZi4xTAuqivkgnzv+CExwq9dc0kMwI=; h=Subject:Cc:Message-Id:From:To:Date:In-Reply-To:Mime-Version: References; b=iUWDXZbQrG96h7MPlRzeawexlEvw8tO0i9IBEns6zWbRbImdrHsMgO3oHk2uAqvHbexSviZbuTZw9BQbOGa3GxRE6qsQ2jZylU7zXXXYUfzK0FzkTDOW02mYck64b9QjZwJmgLqyo+fv0pFB9KdPaywluwaxBu8eyuFbf8whLf4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gahingwoo.com; spf=pass smtp.mailfrom=gz.d.sender-sib.com; dkim=pass (2048-bit key) header.d=gahingwoo.com header.i=@gahingwoo.com header.b=KSP76tC2; arc=none smtp.client-ip=77.32.148.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gahingwoo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gz.d.sender-sib.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gahingwoo.com header.i=@gahingwoo.com header.b="KSP76tC2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gahingwoo.com; q=dns/txt; s=brevo2; bh=7x6aERVipVHaG0xRD6KC0RgCFBCYOOqTbyO/Xpmab5Y=; h=from:subject:date:to:cc:mime-version:content-transfer-encoding:in-reply-to:references:list-unsubscribe:x-csa-complaints:list-unsubscribe-post:message-id:x-sib-id:feedback-id; b=KSP76tC2vugGSQyH5D7TIeFtunes8PbJc26mxOfxuFDtJOquc6afplBQ4IE2rsteZk9f0HEu+mbb nb2USuwbrSrq/3o1d/36dXPp2TPJGxAiZoByTeXyUHDhRf2FQVaAecBjkXGYKcJzYFDZYuqdZi+6 88J/ClLjYYIiopT7zXtEwBUPhYxNs/3FIkzPztlOWBM6/Y02K9ucWYqHrCAB6EW8wBOYPK9chNqm 5dn8wTtEVVwWC2AMFfBlekxvV4mAacr2Mn54oo3BvgH6k67kI8NANMQd/c6xOyucg+QBaALPXrJH FIxdD2ognk5Bz0nOBHNO2w0Sor1bzWLjg72SmA== Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO X-sib-id: E1cRYDXyxBE3XJJEEMvRMgKS9hPNLJu_pfsqV_W7KSWEkxohZIkGGDGqJ3K2Oc4L0jfKOqFiOI9KWC5dpxS22jWq1f8-cbrjaBkZzEuR07Ys4-70e7zrdIOcKQAd7jeGirvsR7Fodti3u64Dqzcsu31WDXtprR8Ie7oWl6T4QSZN_Ujs_3McxcvVWw Cc: , , , , , , , Origin-messageId: <20260716065537.2466151-1-gahing@gahingwoo.com> Message-Id: <8fdb072c-5301-4bf0-86ab-d543a113718a@smtp-relay.sendinblue.com> List-Unsubscribe-Post: List-Unsubscribe=One-Click Feedback-ID: 77.32.148.26:11677070_-1:11677070:Sendinblue From: "Jiaxing Hu" X-CSA-Complaints: csa-complaints@eco.de X-Mailin-EID: NDg1NjE3NDAyfmxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmd%2BPDIwMjYwNzE2MDY1NTM3LjI0NjYxNTEtMS1nYWhpbmdAZ2FoaW5nd29vLmNvbT5%2BZ3ouZC5zZW5kZXItc2liLmNvbQ%3D%3D To: Date: Thu, 16 Jul 2026 18:55:37 +1200 In-Reply-To: <20260716014059.1966E1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260716012838.2353939-1-huhuvmb88@gmail.com> <20260716012838.2353939-3-huhuvmb88@gmail.com> <20260716014059.1966E1F000E9@smtp.kernel.org> X-Mailer: git-send-email 2.43.0 Content-Transfer-Encoding: quoted-printable (Replying from my own domain; v1 went out as huhuvmb88@gmail.com. Same person, I will use this address from v2 on.) Thanks. Most of this is valid, v2 coming. I ran dtbs_check too; it agrees and finds more. > [High] Type-C DP Altmode configuration errors (SVID format, missing > mode-switch, and misplaced SVID) Correct, and worse. dtbs_check rejects the node: the altmodes child must be named "displayport", not altmode@0 with a reg, and svid must be /bits/ 16. The svid I put on &usbdp_phy is not in that binding at all (it has additionalProperties: false), and mode-switch is missing. > [High] Wireless (SYN43752 WiFi/BT) missing child nodes and unreferenced > pinctrls > [Low] The gmac0_rst pinctrl is defined but omitted from &gmac0 Correct. bt_reg_on, wifi_host_wake_irq and gmac0_rst are all unreferenced. I will drop them rather than guess at wifi/bt child nodes, and drop the WiFi/BT claim from the commit message. > [Medium] ES8388 audio is advertised in the commit message but > functionally missing Correct. The node is disabled and its compatible is wrong too (the binding wants everest,es8328). Dropping the node and the claim. > [Medium] Missing vmmc-supply and vqmmc-supply for the eMMC This one I do not think holds. Every rk3576 board upstream (sige5, evb1/evb2, roc-pc, nanopi-r76s, dshanpi-a1) uses full-pwr-cycle-in-suspend without supplies, and dtbs_check does not flag it. Not in the report, but also fixed in v2: the fusb302 port node is not allowed by its binding (the role-switch endpoint belongs in the connector's ports), and the wifi-poweren-gpio pinctrl node name collides with gpio-consumer. Also the PHY reset. I had it as snps,reset-gpios, which is both misspelled (the schema property is singular) and deprecated. v2 describes it on the MDIO bus instead: &mdio0 { reset-gpios =3D <&gpio2 RK_PB3 GPIO_ACTIVE_LOW>; reset-delay-us =3D <20000>; reset-post-delay-us =3D <100000>; rgmii_phy0: phy@1 { ... }; }; That is the only spelling that works here. __mdiobus_register() releases a bus level reset before mdiobus_scan_bus_c22(), whereas a per-PHY reset-gpios is applied by phylib only after the PHY has been found, which never happens for a PHY that boots held in reset. Checked all three on hardware: per-PHY reset leaves the PHY dark, the bus level reset brings it up and the link comes up at 1000 Mbit/s. dtbs_check is clean on v2, with no deprecated properties left. Jiaxing