From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751404AbdGQO0E (ORCPT <rfc822;w@1wt.eu>);
        Mon, 17 Jul 2017 10:26:04 -0400
Received: from mail.kernel.org ([198.145.29.99]:49648 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751278AbdGQO0C (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 17 Jul 2017 10:26:02 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 452FE22B57
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=chao@kernel.org
Subject: Re: [f2fs-dev] [PATCH] f2fs: include seq_file.h for sysfs.c
To: Jaegeuk Kim <jaegeuk@kernel.org>, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Cc: Eric Biggers <ebiggers@google.com>
References: <20170714010138.68665-1-jaegeuk@kernel.org>
From: Chao Yu <chao@kernel.org>
Message-ID: <8fe6971d-a71b-7641-de71-cd68adff2b74@kernel.org>
Date: Mon, 17 Jul 2017 22:25:27 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170714010138.68665-1-jaegeuk@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jaegeuk,

On 2017/7/14 9:01, Jaegeuk Kim wrote:
> This patch includes seq_file.h to avoid compile error.

I didn't hit the error, I guess that's because we have included f2fs_fs.h
in sysfs.c, the inclusion relation is like this:
- sysfs.c
 - f2fs_fs.h
  - pagemap.h
   - fs.h
    - struct seq_file

Thanks,

> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>  fs/f2fs/sysfs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> index 9adc202fcd6f..71191d89917d 100644
> --- a/fs/f2fs/sysfs.c
> +++ b/fs/f2fs/sysfs.c
> @@ -11,6 +11,7 @@
>   */
>  #include <linux/proc_fs.h>
>  #include <linux/f2fs_fs.h>
> +#include <linux/seq_file.h>
>  
>  #include "f2fs.h"
>  #include "segment.h"
>