From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E44F52797A9; Tue, 15 Apr 2025 09:56:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744711008; cv=none; b=pyEurRW36yHjIHyIz+r87FDBN1lg9srI0lcCY0cd14fJALO01+BWoLSMWce+SgyR7LiJ6xoafN0xHhOsuCceguLRJoHXi08MOkURYDTC1qGs30ax28UvNdVyh09UXzmayXQefA+x3Z3euuhPeK3b1QiimB7NoKIYnX+T0gp27Hk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744711008; c=relaxed/simple; bh=bgeLGFc6Lu8MfOCTVrnl63YOXLXNQYS+dPUwg8vroI0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dsMLebaHGkMD+W41QarLcMnwzP0tdCC5/X8DvPsPabylyMI1clbB7h5i3ftQCCKHrSUtFbE0x16nI/tvoGOTz0b1f+7RlnwrVsGYcouDFWFze/pMDFpkaswJVZURyXygwzIpGMVjUbDVis69Yp6TPxuM6NXfcPBYsC8FysR1TfA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=ocIU88IZ; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="ocIU88IZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1744710998; bh=bgeLGFc6Lu8MfOCTVrnl63YOXLXNQYS+dPUwg8vroI0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ocIU88IZ7QwCkATYSbvGYuue3xupbDKk40EFkuPvP5DPuPBVg9O7BH7v13sO+iQN3 5U50K4eNH39QGjUQt7qtEES1DvnTT5HdINfKU6ajQD3LOZD6G2qC+prUENdAKnRxUp jShtvkgDSrFPEoaoS9s4uq8S8qNEaKQ9Bfjr7k9tCjCkdzaXJHomdapENQqtM8oK9X k1vn18rYuGidWCJ38yap+EJUVRe3AO33dXKBSJGL2twctxS9LLys8dcy/zUmSCQU3w 9JXKaP6EnnnSb5wVsowxQdUsquplEndg8/AoE9UCoIZYdSgYAuiqCW2uJZ8jl+ZXSS DtWgbJRoEKlXQ== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id CE2C017E0FD5; Tue, 15 Apr 2025 11:56:37 +0200 (CEST) Message-ID: <8fe762e3-a9eb-4a9c-81a2-b7a10539b615@collabora.com> Date: Tue, 15 Apr 2025 11:56:37 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: mediatek: mt7988a-bpi-r4: allow hw variants of bpi-r4 To: frank-w@public-files.de, Daniel Golle Cc: Frank Wunderlich , Matthias Brugger , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org References: <20250412102109.101094-1-linux@fw-web.de> <36fe0778-399a-4406-8516-54b968cd9073@collabora.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 15/04/25 10:07, Frank Wunderlich ha scritto: > Am 15. April 2025 09:36:43 MESZ schrieb AngeloGioacchino Del Regno : >> Il 14/04/25 14:32, Daniel Golle ha scritto: >>> On Mon, Apr 14, 2025 at 11:27:23AM +0200, AngeloGioacchino Del Regno wrote: >>>> Il 12/04/25 12:21, Frank Wunderlich ha scritto: >>>>> From: Frank Wunderlich >>>>> >>>>> Sinovoip has released other variants of Bananapi-R4 board. >>>>> The known changes affecting only the LAN SFP+ slot which is replaced >>>>> by a 2.5G phy with optional PoE. >>>>> >>>>> Just move the common parts to a new dtsi and keep differences (only >>>>> i2c for lan-sfp) in dts. > >>>> This should at least have some different compatible, if not probably also a >>>> different model string - as it's a different device. >>>> >>>> compatible = "bananapi,bpi-r4-2g5", "bananapi,bpi-r4", "mediatek,mt7988a"; >>> >>> Imho it doesn't make sense to declare compatibility with the >>> "bananapi,bpi-r4" as the "bananapi,bpi-r4-2g5" is NOT compatible with the >>> "bananapi,bpi-r4". It's a different board and using firmware meant for the >>> "bananapi,bpi-r4-2g5" on the "bananapi,bpi-r4" (or vice versa) will result >>> in a non-working Ethernet port. >>> >> >> Is this device a BananaPi R4 variant, or is it a completely different device? > > The only difference is that sfp-lan is replaced by RJ45 socket with mt7988 internal phy. > Perfect, then: - The only difference is one routing - The base board is the same - Same hw project - The two machines are compatible with each other ...bar one difference ...then the compatibles shall be as I said before :-) >> If this is a completely different device, then it's not even a BananaPi R4, >> otherwise this is compatible with BananaPi R4, with a small variation :-) > > Sinovoip now announces a R4Pro with some more changes (e.g. an external 2.5g switch),but we have no detailed shematic yet. It looks they also plan a R4lite which is based on different SoC (afair mt7987),but this is for sure different device (and so not using this bpi-r4.dtsi). In that case, R4Lite shall not be compatible with R4, as the name may be the same, but in practice it's a different machine. > > But basicly all are named BPi-R4. I guess R4Pro will also get own dts as too much changed. If R4pro is a redesign of the R4 board, that would not be compatible, as it would not be the same base design; otherwise, I'm sure you have well understood how it works for the compatibles, anyway :D Cheers! > >> Cheers, >> Angelo > > > regards Frank