From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5D0EC433FE for ; Sun, 6 Nov 2022 01:18:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229619AbiKFBSt convert rfc822-to-8bit (ORCPT ); Sat, 5 Nov 2022 21:18:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbiKFBSr (ORCPT ); Sat, 5 Nov 2022 21:18:47 -0400 Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A5C211448 for ; Sat, 5 Nov 2022 18:18:46 -0700 (PDT) Received: from omf04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4CB43A0968; Sun, 6 Nov 2022 01:18:45 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf04.hostedemail.com (Postfix) with ESMTPA id B045B20024; Sun, 6 Nov 2022 01:17:47 +0000 (UTC) Message-ID: <8fea8008f0ebb85d7e893513117347712e68fba5.camel@perches.com> Subject: Re: [PATCH v2 3/3] staging: rtl8192e: remove unnecesscary macro defines From: Joe Perches To: Jacob Bai , gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Date: Sat, 05 Nov 2022 18:18:41 -0700 In-Reply-To: <6cdf838429ca9b553fb572f55a53ec25fa4e5f6a.1667694826.git.jacob.bai.au@gmail.com> References: <6cdf838429ca9b553fb572f55a53ec25fa4e5f6a.1667694826.git.jacob.bai.au@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Stat-Signature: kx6q3pjzbf487pw7qw8q4b94uwbmijc6 X-Rspamd-Server: rspamout01 X-Rspamd-Queue-Id: B045B20024 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX19yKjAvG44W46awVvnMK0OggVPJz+h+ttU= X-HE-Tag: 1667697467-330742 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2022-11-06 at 12:11 +1100, Jacob Bai wrote: > remove useless macro defines [] > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c > index eabb4187d907..aad1842857c0 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c > +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c > @@ -307,12 +307,12 @@ void rtl92e_config_mac(struct net_device *dev) > struct r8192_priv *priv = rtllib_priv(dev); > > if (priv->bTXPowerDataReadFromEEPORM) { > - dwArrayLen = MACPHY_Array_PGLength; > - pdwArray = Rtl819XMACPHY_Array_PG; > + dwArrayLen = RTL8192E_MAC_ARRAY_PG_LEN; > + pdwArray = RTL8192E_MAC_ARRAY_PG; Perhaps use ARRAY_SIZE instead.