From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A500C001E0 for ; Thu, 27 Jul 2023 14:28:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232258AbjG0O2X (ORCPT ); Thu, 27 Jul 2023 10:28:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231927AbjG0O2S (ORCPT ); Thu, 27 Jul 2023 10:28:18 -0400 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E3772D40; Thu, 27 Jul 2023 07:28:17 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 36RESCqk025609; Thu, 27 Jul 2023 09:28:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1690468092; bh=y9pWzoHEXofZ+sOTLSSeYKRLZvOZRulYCXmFPG+LS7M=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=GrQaZ8hZfUtVIDEe3SOn8ucCJgzdL5q9eNXZ11oWoEKwnxs2dXg4h0jeoOiJ9iU2n mE2TorrxwR3bDq0a54liCqtq4H+ZyVGU2kqTVg3/2p1OlZv2gDx1kJ3sDtcu/R78rl QhHXf1RiB9s4fL7X15ztOWS86Fhsa0A6WL8Iqg6A= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 36RESCGn022502 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 27 Jul 2023 09:28:12 -0500 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 27 Jul 2023 09:28:11 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 27 Jul 2023 09:28:11 -0500 Received: from [172.24.227.6] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 36RES7n3010344; Thu, 27 Jul 2023 09:28:07 -0500 Message-ID: <8fef77fb-d3bf-eab1-0734-919ebf2e61af@ti.com> Date: Thu, 27 Jul 2023 19:58:06 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] dt-bindings: media: Add bindings for Imagination E5010 JPEG Encoder driver Content-Language: en-US To: Krzysztof Kozlowski , , , , , , , CC: , , , , , , , , References: <20230726162615.1270075-1-devarsht@ti.com> From: Devarsh Thakkar In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, Thanks for the quick review. On 26/07/23 22:03, Krzysztof Kozlowski wrote: > On 26/07/2023 18:26, Devarsh Thakkar wrote: >> Add dt-bindings for Imagination E5010 JPEG Encoder driver which is >> implemented as stateful V4L2 M2M driver. >> >> Co-developed-by: David Huang >> Signed-off-by: David Huang > > A nit, subject: drop second/last, redundant "bindings for". The > "dt-bindings" prefix is already stating that these are bindings. > > Drop also "driver". Bindings are for hardware, not drivers. > > Prefix starts with media and then dt-bindings. > Agreed. > >> Signed-off-by: Devarsh Thakkar >> --- >> .../bindings/media/img,e5010-jpeg-enc.yaml | 79 +++++++++++++++++++ >> MAINTAINERS | 5 ++ >> 2 files changed, 84 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >> >> diff --git a/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >> new file mode 100644 >> index 000000000000..0060373eace7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >> @@ -0,0 +1,79 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/img,e5010-jpeg-enc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Imagination E5010 JPEG Encoder >> + >> +maintainers: >> + - Devarsh Thakkar >> + >> +description: | >> + The E5010 is a JPEG encoder from Imagination Technologies implemented on >> + TI's AM62A SoC. It is capable of real time encoding of YUV420 and YUV422 >> + inputs to JPEG and M-JPEG. It supports baseline JPEG Encoding up to >> + 8Kx8K resolution. >> + >> +properties: >> + compatible: >> + const: img,e5010-jpeg-enc > > Your description suggests that this is part of TI SoC. Pretty often > licensed blocks cannot be used on their own and need some > customizations. Are you sure your block does not need any customization > thus no dedicated compatible is needed? > There is a wrapper for interfacing this core with TI SoC, I will recheck this interfacing but I believe nothing changes from programming perspective as there is 1-to-1 maintained between the clocks and signals w.r.t actual E5010 core. >> + >> + reg: >> + items: >> + - description: The E5010 main register region >> + - description: The E5010 mmu register region >> + >> + reg-names: >> + items: >> + - const: regjasper >> + - const: regmmu >> + > > Drop reg from both > Agreed. >> + power-domains: >> + maxItems: 1 >> + >> + resets: >> + maxItems: 1 >> + >> + clocks: >> + minItems: 1 >> + maxItems: 2 > > You need to specify the items. Also, no variable number of clocks. Why > would they vary if block is strictly defined? > Agreed, I believe this version of E5010 core only supports single clock, so we can get rid of maxItems: 2. >> + >> + clock-names: >> + minItems: 1 >> + maxItems: 2 > > Instead list the names. > Agreed. >> + >> + interrupts: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - reg-names >> + - interrupts >> + - clocks >> + - clock-names >> + - power-domains >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + #include >> + >> + cbass_main { > > That's some weird name. Probably you meant soc. Anyway, underscores are > not allowed. Yes, I think I can put soc. cbass_main is specific to TI (soc interconnect bus). > >> + #address-cells = <2>; >> + #size-cells = <2>; >> + e5010: e5010@fd20000 { > > Node names should be generic. See also an explanation and list of > examples (not exhaustive) in DT specification: > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > Yes, video-codec is the nearest one, but this is not really a codec as it only supports encoding, is it fine to name node as jpeg-enc ? > > Drop the label. > Agreed. Best Regards, Devarsh >> + compatible = "img,e5010-jpeg-enc"; >> + reg = <0x00 0xfd20000 0x00 0x100>, >> + <0x00 0xfd20200 0x00 0x200>; >> + reg-names = "regjasper", "regmmu"; >> + clocks = <&k3_clks 201 0>; >> + clock-names = "core_clk"; >> + power-domains = <&k3_pds 201 TI_SCI_PD_EXCLUSIVE>; >> + interrupts = ; >> + }; >> + }; > > > Best regards, > Krzysztof >