mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Ludovic Desroches <ludovic.desroches@microchip.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>
Cc: <alexandre.belloni@bootlin.com>, <robh+dt@kernel.org>,
	<mark.rutland@arm.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: at91: sama5d2_ptc_ek: fix nand pinctrl
Date: Fri, 7 Sep 2018 10:56:10 +0200	[thread overview]
Message-ID: <8ff626a5-8f8a-1e75-ec3d-2a6004289747@microchip.com> (raw)
In-Reply-To: <20180907081851.15911-1-ludovic.desroches@microchip.com>

On 07/09/2018 at 10:18, Ludovic Desroches wrote:
> The drive strength has to be set to medium otherwise some data
> corruption may happen.
> 
> Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
> 
> Hi,
> 
> This fix depends on the support of the drive-strength for the atmel pio4
> pinctroller. It has been added in v4.19 but I omitted to send it at the
> same time.

Could be good to be queued for "4.19-fixes".

Best regards,
   Nicolas

> Ludovic
> 
>   arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts b/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
> index b10dccd0958f..3b1baa8605a7 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
> @@ -11,6 +11,7 @@
>   #include "sama5d2-pinfunc.h"
>   #include <dt-bindings/mfd/atmel-flexcom.h>
>   #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/pinctrl/at91.h>
>   
>   / {
>   	model = "Atmel SAMA5D2 PTC EK";
> @@ -299,6 +300,7 @@
>   							 <PIN_PA30__NWE_NANDWE>,
>   							 <PIN_PB2__NRD_NANDOE>;
>   						bias-pull-up;
> +						atmel,drive-strength = <ATMEL_PIO_DRVSTR_ME>;
>   					};
>   
>   					ale_cle_rdy_cs {
> 


-- 
Nicolas Ferre

  reply	other threads:[~2018-09-07  8:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-07  8:18 Ludovic Desroches
2018-09-07  8:56 ` Nicolas Ferre [this message]
2018-09-12 10:38 ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ff626a5-8f8a-1e75-ec3d-2a6004289747@microchip.com \
    --to=nicolas.ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome