From: Jon Hunter <jonathanh@nvidia.com>
To: Svyatoslav Ryhel <clamor95@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Shubhi Garg <shgarg@nvidia.com>
Cc: devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] ARM: tegra: set correct naming for Tegra Note 7
Date: Mon, 12 Feb 2024 16:14:38 +0000 [thread overview]
Message-ID: <8ffbe7ae-67e9-4a3f-9866-3cd744729971@nvidia.com> (raw)
In-Reply-To: <20240212071843.6679-2-clamor95@gmail.com>
On 12/02/2024 07:18, Svyatoslav Ryhel wrote:
> Correct codename of Tegra Note 7 is "tegratab", while model
> name should be "NVIDIA Tegra Note 7". Fix this inconsistency.
>
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
> arch/arm/boot/dts/nvidia/Makefile | 4 ++--
> .../{tegra114-tn7.dts => tegra114-nvidia-tegratab.dts} | 5 +++--
> 2 files changed, 5 insertions(+), 4 deletions(-)
> rename arch/arm/boot/dts/nvidia/{tegra114-tn7.dts => tegra114-nvidia-tegratab.dts} (98%)
>
> diff --git a/arch/arm/boot/dts/nvidia/Makefile b/arch/arm/boot/dts/nvidia/Makefile
> index 7a422f150488..474f3fbbd99d 100644
> --- a/arch/arm/boot/dts/nvidia/Makefile
> +++ b/arch/arm/boot/dts/nvidia/Makefile
> @@ -2,8 +2,8 @@
> dtb-$(CONFIG_ARCH_TEGRA_114_SOC) += \
> tegra114-asus-tf701t.dtb \
> tegra114-dalmore.dtb \
> - tegra114-roth.dtb \
> - tegra114-tn7.dtb
> + tegra114-nvidia-tegratab.dtb \
> + tegra114-roth.dtb
> dtb-$(CONFIG_ARCH_TEGRA_124_SOC) += \
> tegra124-apalis-eval.dtb \
> tegra124-apalis-v1.2-eval.dtb \
> diff --git a/arch/arm/boot/dts/nvidia/tegra114-tn7.dts b/arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts
> similarity index 98%
> rename from arch/arm/boot/dts/nvidia/tegra114-tn7.dts
> rename to arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts
> index bfbdb345575a..30b2ed91be23 100644
> --- a/arch/arm/boot/dts/nvidia/tegra114-tn7.dts
> +++ b/arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts
> @@ -5,8 +5,9 @@
> #include "tegra114.dtsi"
>
> / {
> - model = "Tegra Note 7";
> - compatible = "nvidia,tn7", "nvidia,tegra114";
> + model = "NVIDIA Tegra Note 7";
> + compatible = "nvidia,tegratab", "nvidia,tegra114";
> + chassis-type = "tablet";
No mention of adding the chassis-type in the commit message. Seems like
that should be a separate change.
Jon
--
nvpublic
next prev parent reply other threads:[~2024-02-12 16:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 7:18 [PATCH v1 0/2] Tegra114: switch Tegra Note 7 from tn7 to tegratab Svyatoslav Ryhel
2024-02-12 7:18 ` [PATCH v1 1/2] ARM: tegra: set correct naming for Tegra Note 7 Svyatoslav Ryhel
2024-02-12 7:33 ` Krzysztof Kozlowski
2024-02-12 16:14 ` Jon Hunter [this message]
2024-02-12 16:50 ` Thierry Reding
2024-02-12 7:18 ` [PATCH v1 2/2] dt-bindings: arm: tegra: document NVIDIA Tegra Note 7 properly Svyatoslav Ryhel
2024-02-12 7:32 ` Krzysztof Kozlowski
2024-02-12 16:13 ` [PATCH v1 0/2] Tegra114: switch Tegra Note 7 from tn7 to tegratab Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ffbe7ae-67e9-4a3f-9866-3cd744729971@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shgarg@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®