From: David Brown <davidb@codeaurora.org>
To: Paul Mundt <lethal@linux-sh.org>
Cc: Julia Lawall <julia@diku.dk>,
kernel-janitors@vger.kernel.org,
Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] drivers/video/msm/mdp.c: adjust error handling code
Date: Wed, 13 Jul 2011 10:49:46 -0700 [thread overview]
Message-ID: <8ya4o2q2hqd.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <20110713081318.GB13701@linux-sh.org> (Paul Mundt's message of "Wed, 13 Jul 2011 17:13:19 +0900")
On Wed, Jul 13 2011, Paul Mundt wrote:
>> I wonder if the error handling code at the end of the function should be
>> calling clk_put as well? In that case, having a separate label for this
>> case would be useful. Otherwise, one of error_request_irq and error_get_clk
>> can be deleted
>>
> The MSM implementation for it is simply a nop, so it's not going to
> really matter one way or the other. In terms of general consistency it
> might be worth implementing.
Today, at least. Hopefully this will get better, since we can turn off
our clocks.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
prev parent reply other threads:[~2011-07-13 17:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 14:11 Julia Lawall
2011-07-13 8:13 ` Paul Mundt
2011-07-13 17:49 ` David Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ya4o2q2hqd.fsf@huya.qualcomm.com \
--to=davidb@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=lethal@linux-sh.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®