From: David Brown <davidb@codeaurora.org>
To: Dima Zavin <dima@android.com>
Cc: Rohit Vaswani <rvaswani@codeaurora.org>,
Daniel Walker <dwalker@codeaurora.org>,
Bryan Huntsman <bryanh@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] msm: Remove arch-specific gpiomux tables
Date: Wed, 09 Feb 2011 13:54:17 -0800 [thread overview]
Message-ID: <8yaei7gq3g6.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <AANLkTimOAOirgH7haDJjf265zdbvoei=f=GGxQEh+5dh@mail.gmail.com> (Dima Zavin's message of "Wed, 9 Feb 2011 12:59:33 -0800")
On Wed, Feb 09 2011, Dima Zavin wrote:
> I don't like this solution of putting the magicly named array into the
> board file. What if I want multiple boards to be built into the same
> kernel? What if I want multiple tables in case I have different
> revisions of the board?
Especially since there is a push by some to be able to build everything
into a single kernel.
> The more correct way would be to add a function to gpiomux.c to be
> able to apply a list of gpiomux configs, something like:
>
> int msm_gpiomux_config_table(struct msm_gpiomux_cfg *table, int num);
Good idea. Although, I think a name like msm_gpiomux_add_configs()
might fit better with other namings.
David
next prev parent reply other threads:[~2011-02-09 21:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-05 1:44 Rohit Vaswani
2011-02-09 20:59 ` Dima Zavin
2011-02-09 21:54 ` David Brown [this message]
2011-02-09 21:57 ` Rohit Vaswani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8yaei7gq3g6.fsf@huya.qualcomm.com \
--to=davidb@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=dima@android.com \
--cc=dwalker@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rvaswani@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome