From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752410Ab1AXVa5 (ORCPT ); Mon, 24 Jan 2011 16:30:57 -0500 Received: from wolverine01.qualcomm.com ([199.106.114.254]:10958 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432Ab1AXVa4 (ORCPT ); Mon, 24 Jan 2011 16:30:56 -0500 X-IronPort-AV: E=McAfee;i="5400,1158,6236"; a="71804972" From: David Brown To: Daniel Walker Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 07/11] msm: Add MSM 8960 cpu_is check In-Reply-To: <1295901976.29639.53.camel@c-dwalke-linux.qualcomm.com> (Daniel Walker's message of "Mon, 24 Jan 2011 12:46:16 -0800") References: <1292384961-8851-1-git-send-email-stepanm@codeaurora.org> <1295468747-22796-1-git-send-email-davidb@codeaurora.org> <1295468747-22796-8-git-send-email-davidb@codeaurora.org> <1295901976.29639.53.camel@c-dwalke-linux.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-Hashcash: 1:20:110124:linux-kernel@vger.kernel.org::ocD/khx4fXRaRPNM:00000000000000000000000000000000007O9 X-Hashcash: 1:20:110124:linux-arm-msm@vger.kernel.org::lr0cx9G1j9nn+N4W:000000000000000000000000000000001hvr X-Hashcash: 1:20:110124:dwalker@codeaurora.org::FU1qzSjDKY3HACib:00000000000000000000000000000000000000079DT X-Hashcash: 1:20:110124:linux-arm-kernel@lists.infradead.org::wy46PbofkXktsXr1:00000000000000000000000007sxk Date: Mon, 24 Jan 2011 13:30:55 -0800 Message-ID: <8yak4hukn00.fsf@huya.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 24 2011, Daniel Walker wrote: > On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: >> diff --git a/arch/arm/mach-msm/include/mach/cpu.h >> b/arch/arm/mach-msm/include/mach/cpu.h >> index e1ba9db..a9481b0 100644 >> --- a/arch/arm/mach-msm/include/mach/cpu.h >> +++ b/arch/arm/mach-msm/include/mach/cpu.h >> @@ -24,6 +24,7 @@ >> #define cpu_is_msm7x30() 0 >> #define cpu_is_qsd8x50() 0 >> #define cpu_is_msm8x60() 0 >> +#define cpu_is_msm8960() 0 > > The naming is just perverted even more here.. What do you want me to call it? #define cpu_is_97d0c886-3768-4998-8925-16f36209d0d1() It's the name of the chip. We've already been through this. The names are unfortunate, but it is what the devices are called. At some point, I may change the msm8x60 to something more specific, such as msm8260, or msm8660, one of the devices that it represents. But this isn't correct, either. There really isn't a good answer. David -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.