From: "André Almeida" <andrealmeid@igalia.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-kernel@vger.kernel.org
Cc: Darren Hart <dvhart@infradead.org>,
Davidlohr Bueso <dave@stgolabs.net>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Valentin Schneider <vschneid@redhat.com>,
Borislav Petkov <bp@alien8.de>, Waiman Long <longman@redhat.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
Anders Roxell <anders.roxell@linaro.org>
Subject: Re: [PATCH 5/5] selftests/futex: fix futex_wait() for 32bit ARM
Date: Wed, 27 Aug 2025 12:50:24 -0300 [thread overview]
Message-ID: <90038e09-69fd-4a8c-b925-007dbac986f4@igalia.com> (raw)
In-Reply-To: <20250827130011.677600-6-bigeasy@linutronix.de>
Em 27/08/2025 10:00, Sebastian Andrzej Siewior escreveu:
> From: Dan Carpenter <dan.carpenter@linaro.org>
>
> On 32bit ARM systems gcc-12 will use 32bit timestamps while gcc-13 and
> later will use 64bit timestamps. The problem is that SYS_futex will
> continue pointing at the 32bit system call. This makes the futex_wait
> test fail like this:
>
> waiter failed errno 110
> not ok 1 futex_wake private returned: 0 Success
> waiter failed errno 110
> not ok 2 futex_wake shared (page anon) returned: 0 Success
> waiter failed errno 110
> not ok 3 futex_wake shared (file backed) returned: 0 Success
>
> Instead of compiling differently depending on the gcc version, use the
> -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 options to ensure that we are
> building with 64bit timestamps. Then use ifdefs to make SYS_futex point
> to the 64bit system call.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> Tested-by: Anders Roxell <anders.roxell@linaro.org>
> Link: https://lore.kernel.org/r/ebd4a415169f9a3153bbd3c1fe6244511c9d1cb3.1756217858.git.dan.carpenter@linaro.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: André Almeida <andrealmeid@igalia.com>
next prev parent reply other threads:[~2025-08-27 15:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 13:00 [PATCH 0/5] selftests/futex: Collected fixups Sebastian Andrzej Siewior
2025-08-27 13:00 ` [PATCH 1/5] selftests/futex: Remove the -g parameter from futex_priv_hash Sebastian Andrzej Siewior
2025-08-27 15:38 ` André Almeida
2025-09-01 14:28 ` [tip: locking/futex] " tip-bot2 for Sebastian Andrzej Siewior
2025-08-27 13:00 ` [PATCH 2/5] selftests/futex: Fix some futex_numa_mpol subtests Sebastian Andrzej Siewior
2025-08-27 15:40 ` André Almeida
2025-08-29 6:27 ` Sebastian Andrzej Siewior
2025-09-01 14:28 ` [tip: locking/futex] " tip-bot2 for Waiman Long
2025-08-27 13:00 ` [PATCH 3/5] selftests/futex: fix format-security warnings in futex_priv_hash Sebastian Andrzej Siewior
2025-09-01 14:28 ` [tip: locking/futex] selftests/futex: Fix " tip-bot2 for Nai-Chen Cheng
2025-08-27 13:00 ` [PATCH 4/5] selftests/futex: fix typos and grammar " Sebastian Andrzej Siewior
2025-08-27 15:49 ` André Almeida
2025-09-01 14:28 ` [tip: locking/futex] selftests/futex: Fix " tip-bot2 for Gopi Krishna Menon
2025-08-27 13:00 ` [PATCH 5/5] selftests/futex: fix futex_wait() for 32bit ARM Sebastian Andrzej Siewior
2025-08-27 15:50 ` André Almeida [this message]
2025-09-01 14:28 ` [tip: locking/futex] selftests/futex: Fix " tip-bot2 for Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90038e09-69fd-4a8c-b925-007dbac986f4@igalia.com \
--to=andrealmeid@igalia.com \
--cc=anders.roxell@linaro.org \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=dan.carpenter@linaro.org \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®