From: Dinh Nguyen <dinguyen@kernel.org>
To: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] firmware: stratix10-svc: remove RSU exclusion from no-support path
Date: Fri, 18 Sep 2026 10:04:44 -0500 [thread overview]
Message-ID: <9005742e-51d5-465a-8f9f-b4aaf46ccd51@kernel.org> (raw)
In-Reply-To: <0b12d08b135d8bd1744db895050340b5929d5211.1789570907.git.adrian.ho.yin.ng@altera.com>
On 9/16/26 10:12, Adrian Ng Ho Yin wrote:
> Remove the compatibility workaround for older firmware that excluded
> COMMAND_RSU_UPDATE and COMMAND_RSU_STATUS from the no-support callback.
> This exclusion caused receive_cb to never be invoked for these commands
> when firmware returned an unsupported response, leaving callers blocked
> until their completion timeout.
>
> Always invoke receive_cb with SVC_STATUS_NO_SUPPORT when the secure
> firmware does not recognise a command, regardless of command type.
>
> Signed-off-by: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>
> ---
> Link: https://lore.kernel.org/all/94bea0ef315adab7a8f9f9a4514eb961a9ea7be7.1778480470.git.adrian.ho.yin.ng@altera.com/
>
> RESEND: refreshed against socfpga_firmware_for_v7.4; clarify commit
> message (timeout wording, shorter subject).
>
> drivers/firmware/stratix10-svc.c | 19 +++++--------------
> 1 file changed, 5 insertions(+), 14 deletions(-)
>
Applied!
Thanks,
Dinh
prev parent reply other threads:[~2026-09-18 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 6:25 [PATCH] firmware: stratix10-svc: remove RSU command exclusion from no-support callback Adrian Ng Ho Yin
2026-09-16 15:12 ` [PATCH RESEND] firmware: stratix10-svc: remove RSU exclusion from no-support path Adrian Ng Ho Yin
2026-09-18 15:04 ` Dinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9005742e-51d5-465a-8f9f-b4aaf46ccd51@kernel.org \
--to=dinguyen@kernel.org \
--cc=adrian.ho.yin.ng@altera.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®