From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B90FBEB64DD for ; Wed, 9 Aug 2023 08:49:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229512AbjHIItI convert rfc822-to-8bit (ORCPT ); Wed, 9 Aug 2023 04:49:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229886AbjHIItF (ORCPT ); Wed, 9 Aug 2023 04:49:05 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6572D1FD8 for ; Wed, 9 Aug 2023 01:49:03 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-265-c5R6OnldN9G1uT9xX-Cmaw-1; Wed, 09 Aug 2023 09:48:57 +0100 X-MC-Unique: c5R6OnldN9G1uT9xX-Cmaw-1 Received: from AcuMS.Aculab.com (10.202.163.4) by AcuMS.aculab.com (10.202.163.4) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Wed, 9 Aug 2023 09:48:54 +0100 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Wed, 9 Aug 2023 09:48:54 +0100 From: David Laight To: 'Petr Mladek' , Andy Shevchenko CC: Marco Elver , "linux-kernel@vger.kernel.org" , "kasan-dev@googlegroups.com" , "linux-mm@kvack.org" , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Subject: RE: [PATCH v2 2/3] lib/vsprintf: Split out sprintf() and friends Thread-Topic: [PATCH v2 2/3] lib/vsprintf: Split out sprintf() and friends Thread-Index: AQHZycNoqz0YrpkIvk2kVFpZOdRD+K/hpuug Date: Wed, 9 Aug 2023 08:48:54 +0000 Message-ID: <900a99a7c90241698c8a2622ca20fa96@AcuMS.aculab.com> References: <20230805175027.50029-1-andriy.shevchenko@linux.intel.com> <20230805175027.50029-3-andriy.shevchenko@linux.intel.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ... > If you split headers into so many small pieces then all > source files will start with 3 screens of includes. I do not see > how this helps with maintainability. You also slow down compilations. A few extra definitions in a 'leaf' header (one without any #includes) don't really matter. If a header includes other 'leaf' headers that doesn't matter much. But the deep include chains caused by a low level header including a main header are what causes pretty much every header to get included in every compilation. Breaking the deep chains is probably more useful than adding leaf headers for things that are in a header pretty much everything in going to include anyway. The is probably scope for counting the depth of header includes by looking at what each header includes. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)