From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C627E95A8D for ; Mon, 9 Oct 2023 06:39:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345264AbjJIGjC (ORCPT ); Mon, 9 Oct 2023 02:39:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229551AbjJIGjA (ORCPT ); Mon, 9 Oct 2023 02:39:00 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7547EA3; Sun, 8 Oct 2023 23:38:59 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 388F41F38C; Mon, 9 Oct 2023 06:38:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1696833538; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AESDE41+ANOM7UAgWQnSXCMFdnACyy9zeD9Xn0/+BwM=; b=s+lYA2pi+i+r7zPq43RdUNhGzY+F/tGV0sXjXQpTq+j09rcKDYO3axKrulY+VbYMcjqXk/ YyOM19v8s0I/+33sbNwjQvpt0HYLfa/U0JuZ4coLITsHIXWozI5YD1r0YDgZtJMkYM/vaf JKMgKQ8jM6Yi5cYY5lm9YVVjbl8iH0g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1696833538; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AESDE41+ANOM7UAgWQnSXCMFdnACyy9zeD9Xn0/+BwM=; b=C4B6HKVSAYGcMyI6eSIH3VLYZN0JKb1rPitR0c/+POlmXp3xMWRsfIRla9zt2kQvDBo64m B6wbIT71sldrciDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D044313586; Mon, 9 Oct 2023 06:38:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id SLbqIAGgI2UmCgAAMHmgww (envelope-from ); Mon, 09 Oct 2023 06:38:57 +0000 Message-ID: <900e549f-db0f-4c0a-9f67-b7f02294cd14@suse.de> Date: Mon, 9 Oct 2023 08:38:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/10] scsi: libsas: Delete enum sas_class Content-Language: en-US To: John Garry , jejb@linux.ibm.com, martin.petersen@oracle.com, chenxiang66@hisilicon.com, artur.paszkiewicz@intel.com, yanaijie@huawei.com, jinpu.wang@cloud.ionos.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, dlemoal@kernel.org References: <20230814141022.36875-1-john.g.garry@oracle.com> <20230814141022.36875-3-john.g.garry@oracle.com> From: Hannes Reinecke In-Reply-To: <20230814141022.36875-3-john.g.garry@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/14/23 16:10, John Garry wrote: > enum sas_class prob would have been useful if function sas_show_class() was > ever implemented, which it wasn't. > > enum sas_class is used as asd_sas_port.class and asd_sas_phy.class, which > are only ever set, so delete these members and the enum. > > Signed-off-by: John Garry > --- > drivers/scsi/aic94xx/aic94xx_hwi.c | 1 - > drivers/scsi/hisi_sas/hisi_sas_main.c | 1 - > drivers/scsi/isci/phy.c | 1 - > drivers/scsi/libsas/sas_internal.h | 1 - > drivers/scsi/libsas/sas_port.c | 2 -- > drivers/scsi/mvsas/mv_init.c | 1 - > drivers/scsi/pm8001/pm8001_init.c | 1 - > include/scsi/libsas.h | 7 ------- > 8 files changed, 15 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman