From: Andy Lutomirski <luto@kernel.org>
To: x86@kernel.org
Cc: Sasha Levin <sashal@kernel.org>,
linux-kernel@vger.kernel.org,
Andrew Cooper <andrew.cooper3@citrix.com>,
Juergen Gross <jgross@suse.com>,
Andy Lutomirski <luto@kernel.org>
Subject: [PATCH fsgsbase v2 1/4] selftests/x86/fsgsbase: Fix a comment in the ptrace_write_gsbase test
Date: Fri, 26 Jun 2020 10:24:27 -0700 [thread overview]
Message-ID: <901034a91a40169ec84f1f699ea86704dff762e4.1593192140.git.luto@kernel.org> (raw)
In-Reply-To: <cover.1593192140.git.luto@kernel.org>
A comment was unclear. Fix it.
Fixes: 5e7ec8578fa3 ("selftests/x86/fsgsbase: Test ptracer-induced GS base write with FSGSBASE")
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
tools/testing/selftests/x86/fsgsbase.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/x86/fsgsbase.c b/tools/testing/selftests/x86/fsgsbase.c
index 9a4349813a30..f47495d2f070 100644
--- a/tools/testing/selftests/x86/fsgsbase.c
+++ b/tools/testing/selftests/x86/fsgsbase.c
@@ -498,7 +498,8 @@ static void test_ptrace_write_gsbase(void)
* base would zero the selector. On newer kernels,
* this behavior has changed -- poking the base
* changes only the base and, if FSGSBASE is not
- * available, this may not effect.
+ * available, this may have no effect once the tracee
+ * is resumed.
*/
if (gs == 0)
printf("\tNote: this is expected behavior on older kernels.\n");
--
2.25.4
next prev parent reply other threads:[~2020-06-26 17:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 17:24 [PATCH fsgsbase v2 0/4] x86/fsgsbase: Some fixes Andy Lutomirski
2020-06-26 17:24 ` Andy Lutomirski [this message]
2020-07-01 13:33 ` [tip: x86/fsgsbase] selftests/x86/fsgsbase: Fix a comment in the ptrace_write_gsbase test tip-bot2 for Andy Lutomirski
2020-06-26 17:24 ` [PATCH fsgsbase v2 2/4] selftests/x86/fsgsbase: Add a missing memory constraint Andy Lutomirski
2020-07-01 13:33 ` [tip: x86/fsgsbase] " tip-bot2 for Andy Lutomirski
2020-06-26 17:24 ` [PATCH fsgsbase v2 3/4] x86/ptrace: Fix 32-bit PTRACE_SETREGS vs fsbase and gsbase Andy Lutomirski
2020-07-01 13:33 ` [tip: x86/fsgsbase] " tip-bot2 for Andy Lutomirski
2020-06-26 17:24 ` [PATCH fsgsbase v2 4/4] x86/fsgsbase: Fix Xen PV support Andy Lutomirski
2020-06-29 5:17 ` Jürgen Groß
2020-06-29 11:07 ` Andrew Cooper
2020-07-01 13:33 ` [tip: x86/fsgsbase] " tip-bot2 for Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=901034a91a40169ec84f1f699ea86704dff762e4.1593192140.git.luto@kernel.org \
--to=luto@kernel.org \
--cc=andrew.cooper3@citrix.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome