From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753520AbeADQcb (ORCPT + 1 other); Thu, 4 Jan 2018 11:32:31 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:35404 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752463AbeADQc3 (ORCPT ); Thu, 4 Jan 2018 11:32:29 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A793D60208 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH V4 11/26] iommu/amd: deprecate pci_get_bus_and_slot() To: Gary R Hook , linux-pci@vger.kernel.org, timur@codeaurora.org Cc: linux-arm-msm@vger.kernel.org, "open list:AMD IOMMU (AMD-VI)" , linux-arm-kernel@lists.infradead.org, open list References: <1513661883-28662-1-git-send-email-okaya@codeaurora.org> <1513661883-28662-12-git-send-email-okaya@codeaurora.org> <8a5dad82-2886-2a51-28bc-b84ab253c361@codeaurora.org> <46ccdb85-1c23-c9eb-994c-9a66e6fce7cc@amd.com> From: Sinan Kaya Message-ID: <9014a9e1-9545-4f3c-08c2-8e8eb4762101@codeaurora.org> Date: Thu, 4 Jan 2018 11:32:26 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <46ccdb85-1c23-c9eb-994c-9a66e6fce7cc@amd.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 1/4/2018 11:28 AM, Gary R Hook wrote: > On 01/04/2018 06:25 AM, Sinan Kaya wrote: >> On 12/19/2017 12:37 AM, Sinan Kaya wrote: >>> pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as >>> where a PCI device is present. This restricts the device drivers to be >>> reused for other domain numbers. >>> >>> Getting ready to remove pci_get_bus_and_slot() function in favor of >>> pci_get_domain_bus_and_slot(). >>> >>> Hard-code the domain number as 0 for the AMD IOMMU driver. > > > >> >> Any comments from the IOMMU people? >> > > pci_get_bus_and_slot() appears to (now) be a convenience function that wraps pci_get_domain_bus_and_slot() while using a 0 for the domain value. Exactly what you are doing here, albeit in a more overt way. > > How is this patch advantageous? Seems to me that if other domains need to be enabled, that driver could be changed if and when that requirement arises. > > But perhaps I'm missing a nuance here. > > The benefit of the change was discussed here: https://lkml.org/lkml/2017/12/19/349 I hope it helps. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.