From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26EBFC3DA7A for ; Wed, 28 Dec 2022 03:57:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229918AbiL1D44 (ORCPT ); Tue, 27 Dec 2022 22:56:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229579AbiL1D4y (ORCPT ); Tue, 27 Dec 2022 22:56:54 -0500 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D6E7766E for ; Tue, 27 Dec 2022 19:56:52 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 04EDA5C00AE; Tue, 27 Dec 2022 22:56:52 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 27 Dec 2022 22:56:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1672199811; x= 1672286211; bh=nNQzqCe5zmOATT2jxUQw+cDTgzFKZ4/xmHDTPVepV/k=; b=D GengyLG6n+MGuxF34MbI2RWwssG4W0LzEgDWZV2POn6hh+fNvQstG868POWFv+9G Lu1O8PmtjEJpfDg0m6/ULkUDWBrMIl3ZSbg5tm/z+SltiVa5VOizXiQh46eJ8QJd rDuSbGggAVVg7Gh3B4mtTjGvRGrnoPOvucrFb8msyCvZWCwKotuIjx0zJ81Rn+5Q fXikVLFL0CpJMQRnTkHsL1F1DKAk8nap/VrjVhB0QxojcSiN2B8oQS2jv1MAooY5 jpr1IkpCcEddwDZDTdgnBH8gpiBAqN4UXZ3C/gqiXNY5VwrfqN/CNRVruQ9bCxyy IwCDPcB2Zo3z0h2Zkpy6w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1672199811; x= 1672286211; bh=nNQzqCe5zmOATT2jxUQw+cDTgzFKZ4/xmHDTPVepV/k=; b=t EfbjtJfNY62p1XC4Ul9Dl5ZCooGB2+FGMgrUKVJL+UENKfZasKdObWLNF56Oman9 q4ql349Oy7btcbNQGL9R26Kt9j+jCiEi/kZw1AtalnnLoGCwJgxZin9CNb9H0bo8 OR5lXaFv1246GJg6yg7BCU2EpVPpWsVIbQypfF8UEYnNBnpBwQQ+uhKtbFX2FiHW aTzQEpfBicCGlk6H+kQK3yglbs9RnMoE6T3jbcl/vK7sYTTB+qP1E/AV5nn1R7B9 WHy+RRj/RdgV/onxrqU5IzePalHLb/EO72OSOQLM4Hnz8q5ygGA2FjMGkotwN0fX PlRgP4rPqoKid+tt8BeCA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedriedugdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfvvehfhffujggtgfesthejredttdefjeenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepheettdefgeeuudelvdffleejheejueeludduiedvkeffgeetueev vdelvdetfeejnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsrghmuhgvlhesshhhohhllhgr nhgurdhorhhg X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Dec 2022 22:56:50 -0500 (EST) Message-ID: <9015e4b4-4652-3c19-b845-4fa8855559d7@sholland.org> Date: Tue, 27 Dec 2022 21:56:50 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Content-Language: en-US To: Aren Moynihan , Lee Jones Cc: Ondrej Jirman , linux-kernel@vger.kernel.org, Chen-Yu Tsai References: <20221208220225.635414-1-aren@peacevolution.org> From: Samuel Holland Subject: Re: [PATCH v2] mfd: axp20x: fix order of pek rise and fall events In-Reply-To: <20221208220225.635414-1-aren@peacevolution.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/8/22 16:02, Aren Moynihan wrote: > The power button can get "stuck" if the rising edge and falling edge irq > are read in the same pass. This can often be triggered when resuming > from suspend if the power button is released before the kernel handles > the interrupt. > > Swapping the order of the rise and fall events makes sure that the press > event is handled first, which prevents this situation. > > Signed-off-by: Aren Moynihan > --- > changes in v2: > - add comments describing the reason these are out of bit order > > previous version: > https://lore.kernel.org/lkml/20221123230741.2430813-1-aren@peacevolution.org/T/ > > include/linux/mfd/axp20x.h | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) Reviewed-by: Samuel Holland Tested-by: Samuel Holland